Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: apps/app_shim/extension_app_shim_handler_mac.h

Issue 461303002: [Mac] Bounce app shims when app windows request attention. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: apps/app_shim/extension_app_shim_handler_mac.h
diff --git a/apps/app_shim/extension_app_shim_handler_mac.h b/apps/app_shim/extension_app_shim_handler_mac.h
index 0f7ae0c37195f83ca777747bbb42acf5fddfb302..6bb0bf696452f578168506bfcbe3579f777c9264 100644
--- a/apps/app_shim/extension_app_shim_handler_mac.h
+++ b/apps/app_shim/extension_app_shim_handler_mac.h
@@ -80,8 +80,14 @@ class ExtensionAppShimHandler : public AppShimHandler,
static void FocusAppForWindow(AppWindow* app_window);
// Brings the window to the front without showing it and instructs the shim to
- // request user attention. Returns false if there is no shim for this window.
- static bool RequestUserAttentionForWindow(AppWindow* app_window);
+ // request user attention. If there is no shim, show the app and return false.
+ static bool ActivateAndRequestUserAttentionForWindow(AppWindow* app_window);
+
+ // Instructs the shim to request user attention. Returns false if there is no
+ // shim for this window.
+ static bool RequestUserAttentionForWindow(
tapted 2014/08/13 03:37:08 return void? I don't think anything uses the retur
jackhou1 2014/08/13 05:53:46 Done.
+ AppWindow* app_window,
+ AppShimAttentionType attention_type);
// Called by AppControllerMac when Chrome hides.
static void OnChromeWillHide();

Powered by Google App Engine
This is Rietveld 408576698