extensions/extensions.gyp - Issue 461273003: Rework ExtensionApiUnittest to run in extensions_unittests, removing its Chrome dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/extensions.gyp

Issue 461273003: Rework ExtensionApiUnittest to run in extensions_unittests, removing its Chrome dependencies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/extension_api_unittest.cc ('K') | « extensions/browser/extension_api_unittest.cc ('k') | extensions/test/extensions_unittests_main.cc » ('j') | extensions/test/extensions_unittests_main.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/extensions.gyp

diff --git a/extensions/extensions.gyp b/extensions/extensions.gyp

index fdcb6d759eaa604a29e71929977b4d3e38f3fee8..142ae5051f0fb3efe0905023ec994c22e23c5545 100644

--- a/extensions/extensions.gyp

+++ b/extensions/extensions.gyp

@@ -819,6 +819,7 @@

'type': 'executable',

'dependencies': [

'../base/base.gyp:base',

+ '../base/base.gyp:base_prefs_test_support',

James Cook 2014/08/13 16:11:36 Does extensions/BUILD.gn need to be modified?

Yoyo Zhou 2014/08/13 22:53:43 I looked at this briefly; uncommenting extensions:

'../base/base.gyp:test_support_base',

'../components/components.gyp:keyed_service_content',

'../content/content_shell_and_tests.gyp:test_support_content',

@@ -844,10 +845,13 @@

'sources': [

'browser/admin_policy_unittest.cc',

'browser/api/api_resource_manager_unittest.cc',

+ 'browser/api/sockets_tcp/sockets_tcp_api_unittest.cc',

'browser/computed_hashes_unittest.cc',

'browser/content_hash_tree_unittest.cc',

'browser/event_listener_map_unittest.cc',

'browser/event_router_unittest.cc',

+ 'browser/extension_api_unittest.cc',

+ 'browser/extension_api_unittest.h',

'browser/extension_pref_value_map_unittest.cc',

'browser/extension_registry_unittest.cc',

'browser/file_highlighter_unittest.cc',