Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: extensions/browser/api/sockets_tcp/sockets_tcp_api_unittest.cc

Issue 461273003: Rework ExtensionApiUnittest to run in extensions_unittests, removing its Chrome dependencies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/sockets_tcp/sockets_tcp_api_unittest.cc
diff --git a/chrome/browser/extensions/api/sockets_tcp/sockets_tcp_api_unittest.cc b/extensions/browser/api/sockets_tcp/sockets_tcp_api_unittest.cc
similarity index 83%
rename from chrome/browser/extensions/api/sockets_tcp/sockets_tcp_api_unittest.cc
rename to extensions/browser/api/sockets_tcp/sockets_tcp_api_unittest.cc
index e883e7c1233adb3f33588f95c7cd68d3fc2940b7..0ba3b3b6314c79d386037a125bece0c8b584a92c 100644
--- a/chrome/browser/extensions/api/sockets_tcp/sockets_tcp_api_unittest.cc
+++ b/extensions/browser/api/sockets_tcp/sockets_tcp_api_unittest.cc
@@ -3,15 +3,12 @@
// found in the LICENSE file.
#include "base/values.h"
-#include "chrome/browser/browser_process_impl.h"
-#include "chrome/browser/extensions/extension_api_unittest.h"
-#include "chrome/browser/extensions/test_extension_system.h"
-#include "chrome/browser/profiles/profile_manager.h"
-#include "chrome/test/base/testing_browser_process.h"
+#include "content/public/test/test_browser_context.h"
James Cook 2014/08/13 16:11:35 Not for this CL: I wonder if ExtensionsTest should
Yoyo Zhou 2014/08/13 22:53:43 TestBrowserContext doesn't have any notable specia
#include "extensions/browser/api/api_resource_manager.h"
#include "extensions/browser/api/socket/socket.h"
#include "extensions/browser/api/socket/tcp_socket.h"
#include "extensions/browser/api/sockets_tcp/sockets_tcp_api.h"
+#include "extensions/browser/extension_api_unittest.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -32,7 +29,7 @@ class SocketsTcpUnitTest : public ExtensionApiUnittest {
ExtensionApiUnittest::SetUp();
ApiResourceManager<ResumableTCPSocket>::GetFactoryInstance()
- ->SetTestingFactoryAndUse(browser()->profile(),
+ ->SetTestingFactoryAndUse(browser_context(),
ApiResourceManagerTestFactory);
}
};

Powered by Google App Engine
This is Rietveld 408576698