Rework ExtensionApiUnittest to run in extensions_unittests, removing its Chrome dependencies.

extensions/test/extensions_unittests_main.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/base_paths.h"
 #include "base/bind.h"
 #include "base/macros.h"
 #include "base/path_service.h"
 #include "base/test/launcher/unit_test_launcher.h"
 #include "content/public/common/content_client.h"
 #include "content/public/test/content_test_suite_base.h"
 #include "content/public/test/unittest_test_suite.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/extension_paths.h"
 #include "extensions/test/test_extensions_client.h"
 #include "mojo/embedder/embedder.h"
 #include "ui/base/resource/resource_bundle.h"
 
+#if !defined(OS_IOS)
+#include "ui/gl/gl_surface.h"
+#endif
+
 namespace {
 
 // Content client that exists only to register chrome-extension:// scheme with
 // the url module.
 // TODO(jamescook): Should this be merged with ShellContentClient? Should this
 // be a persistent object available to tests?
 class ExtensionsContentClient : public content::ContentClient {
  public:
   ExtensionsContentClient() {}
   virtual ~ExtensionsContentClient() {}
@@ skipping 29 matching lines @@
 };
 
 ExtensionsTestSuite::ExtensionsTestSuite(int argc, char** argv)
     : content::ContentTestSuiteBase(argc, argv) {}
 
 ExtensionsTestSuite::~ExtensionsTestSuite() {}
 
 void ExtensionsTestSuite::Initialize() {
   content::ContentTestSuiteBase::Initialize();
 
+#if !defined(OS_IOS)
+  gfx::GLSurface::InitializeOneOffForTests();

[James Cook, 2014/08/13 16:11:36]

We need a GL surface for this test?  Why?

In theory most of these tests should not need graphics of any sort. If this has
to exist I think it should be moved into individual tests or a base class for
tests.

[Yoyo Zhou, 2014/08/13 22:53:43]

It turns out I don't need it after all. I recall that there was some issue with
startup ordering that led me to put it here.

+#endif
+
   // Register the chrome-extension:// scheme via this circuitous path. Note
   // that this does not persistently set up a ContentClient; individual tests
   // must use content::SetContentClient().
   {
     ExtensionsContentClient content_client;
     RegisterContentSchemes(&content_client);
   }
 
   extensions::RegisterPathProvider();
 
@@ skipping 19 matching lines @@
 
 int main(int argc, char** argv) {
   content::UnitTestTestSuite test_suite(new ExtensionsTestSuite(argc, argv));
 
   mojo::embedder::Init();
   return base::LaunchUnitTests(argc,
                                argv,
                                base::Bind(&content::UnitTestTestSuite::Run,
                                           base::Unretained(&test_suite)));
 }