Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 461253007: fix leak in new createproc (Closed)

Created:
6 years, 4 months ago by reed2
Modified:
6 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/effects/SkColorFilterImageFilter.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
mikerreed
should fix these leaks: http://108.170.220.120:10117/builders/Test-Ubuntu12-ShuttleA-GTX550Ti-x86_64-Release-Valgrind/builds/504/steps/RunDM/logs/stdio
6 years, 4 months ago (2014-08-22 09:46:23 UTC) #1
mikerreed
6 years, 4 months ago (2014-08-22 09:46:46 UTC) #2
reed2
The CQ bit was checked by reed@chromium.org
6 years, 4 months ago (2014-08-22 09:50:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/461253007/1
6 years, 4 months ago (2014-08-22 09:51:31 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-22 09:51:32 UTC) #5
reed2
The CQ bit was unchecked by reed@chromium.org
6 years, 4 months ago (2014-08-22 09:54:10 UTC) #6
reed2
The CQ bit was checked by reed@chromium.org
6 years, 4 months ago (2014-08-22 09:54:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/461253007/1
6 years, 4 months ago (2014-08-22 09:55:31 UTC) #8
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-22 09:55:33 UTC) #9
caryclark
The CQ bit was checked by caryclark@google.com
6 years, 4 months ago (2014-08-22 12:08:17 UTC) #10
caryclark
lgtm
6 years, 4 months ago (2014-08-22 12:08:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/461253007/1
6 years, 4 months ago (2014-08-22 12:08:23 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 12:08:32 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (1) as f0f6c405fe9646be224128fc1dd24c7fc15246ef

Powered by Google App Engine
This is Rietveld 408576698