Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 461253002: Add ProcessArgumentsForPID() (process_util) and its test (Closed)

Created:
6 years, 4 months ago by Mark Mentovai
Modified:
6 years, 4 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Add ProcessArgumentsForPID() (process_util) and its test. TEST=util_test ProcessUtil.ProcessArgumentsForPID R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/5f554ff10e14

Patch Set 1 #

Patch Set 2 : Revise comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -0 lines) Patch
A util/posix/process_util.h View 1 chunk +42 lines, -0 lines 0 comments Download
A util/posix/process_util_mac.cc View 1 1 chunk +102 lines, -0 lines 0 comments Download
A util/posix/process_util_test.cc View 1 chunk +47 lines, -0 lines 0 comments Download
M util/util.gyp View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
6 years, 4 months ago (2014-08-12 23:33:38 UTC) #1
Robert Sesek
LGTM
6 years, 4 months ago (2014-08-14 16:02:04 UTC) #2
Mark Mentovai
6 years, 4 months ago (2014-08-14 16:57:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 5f554ff10e14 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698