content/browser/service_worker/service_worker_registration_handle.cc - Issue 461233004: Fix crash in ServiceWorkerRegistrationHandle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_registration_handle.cc

Issue 461233004: Fix crash in ServiceWorkerRegistrationHandle (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add DCHECK Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_registration_handle.h ('k') | content/browser/service_worker/service_worker_registration_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_registration_handle.cc

diff --git a/content/browser/service_worker/service_worker_registration_handle.cc b/content/browser/service_worker/service_worker_registration_handle.cc

index 7f005aff0fe7e443a3dc03a72f268d1541e6335e..3e333955b9c77bf4ed44bd6ae63ff4bd31333aaa 100644

--- a/content/browser/service_worker/service_worker_registration_handle.cc

+++ b/content/browser/service_worker/service_worker_registration_handle.cc

@@ -33,6 +33,7 @@ ServiceWorkerRegistrationHandle::ServiceWorkerRegistrationHandle(

}

ServiceWorkerRegistrationHandle::~ServiceWorkerRegistrationHandle() {

+ DCHECK(registration_);

registration_->RemoveListener(this);

}

@@ -60,8 +61,6 @@ void ServiceWorkerRegistrationHandle::OnRegistrationFailed(

ServiceWorkerRegistration* registration) {

DCHECK_EQ(registration->id(), registration_->id());

ClearVersionAttributes();

- registration_->RemoveListener(this);

- registration_ = NULL;

}

void ServiceWorkerRegistrationHandle::SetVersionAttributes(