Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 461213002: Remove unused shouldOnlyIncludeDirectChildren (Closed)

Created:
6 years, 4 months ago by rwlbuis
Modified:
6 years, 4 months ago
Reviewers:
Inactive
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove unused shouldOnlyIncludeDirectChildren It seems this one is no longer needed, just the one in HTMLCollection is used. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180131

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M Source/core/dom/LiveNodeList.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rwlbuis
PTAL
6 years, 4 months ago (2014-08-12 22:30:18 UTC) #1
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-08-13 00:34:30 UTC) #2
Inactive
lgtm Right, my bad. I forgot to get rid of it after the refactoring.
6 years, 4 months ago (2014-08-13 00:34:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/461213002/1
6 years, 4 months ago (2014-08-13 00:37:59 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 4 months ago (2014-08-13 01:37:52 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 01:48:58 UTC) #6
Message was sent while issue was closed.
Change committed as 180131

Powered by Google App Engine
This is Rietveld 408576698