Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 461183002: Change QUIC's delayed ack timer from 100ms to 25ms. (Closed)

Created:
6 years, 4 months ago by ramant (doing other things)
Modified:
6 years, 4 months ago
Reviewers:
Jana, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@cleanup_changes_0808
Project:
chromium
Visibility:
Public.

Description

Change QUIC's delayed ack timer from 100ms to 25ms. Rationale: This delay kicks in when the receiver is waiting for a second data packet before sending an ack, and 100ms seems inordinately long for this wait. The timer fires per-packet in low-bandwidth network paths (BW < ~384 kbps), where more frequent acks helps with (i) ack clocking, and (ii) better bw estimation for BBR. Merge internal change: 72788368 R=jri@chromium.org, rch@chromium.org

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M net/quic/quic_connection_test.cc View 2 chunks +1 line, -2 lines 3 comments Download
M net/quic/quic_protocol.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 4 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ramant (doing other things)
6 years, 4 months ago (2014-08-12 21:21:27 UTC) #1
ramant (doing other things)
https://codereview.chromium.org/461183002/diff/1/net/quic/quic_connection_test.cc File net/quic/quic_connection_test.cc (right): https://codereview.chromium.org/461183002/diff/1/net/quic/quic_connection_test.cc#newcode887 net/quic/quic_connection_test.cc:887: return QuicTime::Delta::FromMilliseconds(kMaxDelayedAckTime); hi jri, Used kMaxDelayedAckTime instead of hard ...
6 years, 4 months ago (2014-08-12 21:22:15 UTC) #2
Jana
lgtm Thanks, Raman! https://codereview.chromium.org/461183002/diff/1/net/quic/quic_connection_test.cc File net/quic/quic_connection_test.cc (right): https://codereview.chromium.org/461183002/diff/1/net/quic/quic_connection_test.cc#newcode887 net/quic/quic_connection_test.cc:887: return QuicTime::Delta::FromMilliseconds(kMaxDelayedAckTime); On 2014/08/12 21:22:15, ramant ...
6 years, 4 months ago (2014-08-13 01:28:38 UTC) #3
Ryan Hamilton
lgtm
6 years, 4 months ago (2014-08-13 16:28:24 UTC) #4
ramant (doing other things)
6 years, 4 months ago (2014-08-14 19:59:30 UTC) #5
https://codereview.chromium.org/461183002/diff/1/net/quic/quic_connection_tes...
File net/quic/quic_connection_test.cc (right):

https://codereview.chromium.org/461183002/diff/1/net/quic/quic_connection_tes...
net/quic/quic_connection_test.cc:887: return
QuicTime::Delta::FromMilliseconds(kMaxDelayedAckTime);
On 2014/08/13 01:28:38, Jana wrote:
> On 2014/08/12 21:22:15, ramant wrote:
> > hi jri,
> >   Used kMaxDelayedAckTime instead of hard coding 25. WDYT?
> 
> Sure, that sounds fine.

Acknowledged.

Powered by Google App Engine
This is Rietveld 408576698