Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 461163002: Cleanup namespace usage in Source/core/modules/[mediasource/* to websockets/*] (Closed)

Created:
6 years, 4 months ago by Sunil Ratnu
Modified:
6 years, 4 months ago
Reviewers:
tkent, abarth-chromium
CC:
alecflett+watch_chromium.org, blink-reviews, eric.carlson_apple.com, falken, feature-media-reviews_chromium.org, gyuyoung.kim_webkit.org, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kinuko+fileapi, kinuko+serviceworker, michaeln, nhiroki, philipj_slow, Raymond Toy, serviceworker-reviews, tommyw+watchlist_chromium.org, tyoshino+watch_chromium.org, tzik, yhirano+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Cleanup namespace usage in Source/core/modules/[mediasource/* to websockets/*] Cleanup namespace usage in Source/core/modules/[mediasource/* to websockets/*] - Merge multiple |namespace blink {}| blocks - Remove unnecessary blink:: prefixes - Make blank lines consistent BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180105

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -196 lines) Patch
M Source/modules/mediasource/MediaSource.h View 3 chunks +5 lines, -8 lines 0 comments Download
M Source/modules/mediasource/SourceBuffer.h View 4 chunks +4 lines, -7 lines 0 comments Download
M Source/modules/mediastream/MediaConstraintsImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/MediaDeviceInfo.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/mediastream/MediaStreamTrackSourcesRequestImpl.h View 2 chunks +3 lines, -6 lines 0 comments Download
M Source/modules/mediastream/RTCDTMFSender.h View 2 chunks +8 lines, -11 lines 0 comments Download
M Source/modules/mediastream/RTCDataChannel.h View 2 chunks +12 lines, -15 lines 0 comments Download
M Source/modules/mediastream/RTCIceCandidate.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.h View 5 chunks +11 lines, -11 lines 0 comments Download
M Source/modules/mediastream/RTCSessionDescription.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h View 1 chunk +2 lines, -5 lines 0 comments Download
M Source/modules/mediastream/SourceInfo.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/mediastream/UserMediaRequest.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/navigatorcontentutils/testing/NavigatorContentUtilsClientMock.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/netinfo/NetworkInformation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/push_messaging/PushController.h View 1 chunk +7 lines, -9 lines 0 comments Download
M Source/modules/push_messaging/PushError.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/push_messaging/PushRegistration.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/quota/DeprecatedStorageQuotaCallbacksImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/quota/StorageQuotaCallbacksImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/quota/StorageQuotaClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/screen_orientation/LockOrientationCallback.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientation.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientationController.h View 3 chunks +6 lines, -9 lines 0 comments Download
M Source/modules/serviceworkers/CacheStorage.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/Request.h View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/modules/serviceworkers/Response.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorker.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.h View 3 chunks +10 lines, -13 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainerClient.h View 3 chunks +6 lines, -9 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerError.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h View 2 chunks +8 lines, -11 lines 0 comments Download
M Source/modules/webaudio/AsyncAudioDecoder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/OfflineAudioDestinationNode.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseTask.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseThread.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIAccessor.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/websockets/NewWebSocketChannelImpl.h View 4 chunks +14 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sunil Ratnu
Please review this. Thanks!
6 years, 4 months ago (2014-08-12 21:03:22 UTC) #1
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 4 months ago (2014-08-12 21:12:46 UTC) #2
abarth-chromium
lgtm
6 years, 4 months ago (2014-08-12 21:12:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/461163002/1
6 years, 4 months ago (2014-08-12 21:14:40 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 22:05:05 UTC) #5
Message was sent while issue was closed. 
Change committed as 180105

Powered by Google App Engine
This is Rietveld 408576698