Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 461133002: Revert of Adds some CHECKs to MessagePumpMojo (Closed)

Created:
6 years, 4 months ago by adamk
Modified:
6 years, 4 months ago
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), erikwright+watch_chromium.org, ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Adds some CHECKs to MessagePumpMojo (https://codereview.chromium.org/454433003/) Reason for revert: Speculative revert, attempting to diagnose timing out Blink layout tests on Windows. Original issue's description: > Adds some CHECKs to MessagePumpMojo > > The thread watcher appears to be kicking on when we're trying to > remove a handle. Not sure why. This converts some DCHECKs to CHECKs > and fixes handling of the deadline. I suspect none of this will help, > but it's worth a shot. > > BUG=399769 > TEST=none > R=darin@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288949 TBR=darin@chromium.org,sky@chromium.org NOTREECHECKS=true NOTRY=true BUG=399769 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289057

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -36 lines) Patch
M base/message_loop/message_loop.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/common/data_pipe_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/common/message_pump_mojo.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/common/message_pump_mojo.cc View 6 chunks +15 lines, -33 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
adamk
Created Revert of Adds some CHECKs to MessagePumpMojo
6 years, 4 months ago (2014-08-12 20:32:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/461133002/1
6 years, 4 months ago (2014-08-12 20:38:29 UTC) #2
commit-bot: I haz the power
Change committed as 289057
6 years, 4 months ago (2014-08-12 20:42:18 UTC) #3
Hajime Morrita
6 years, 4 months ago (2014-08-12 22:33:57 UTC) #4
Message was sent while issue was closed.
FYI: The change seemed to causing a kind of busy loop on mojo-pump thread on
Linux.
The browser process consumes 100% cpu time with the original CL.

Powered by Google App Engine
This is Rietveld 408576698