pkg/analysis_services/lib/src/completion/dart_completion_manager.dart - Issue 461063002: add keyword suggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_services/lib/src/completion/dart_completion_manager.dart

Issue 461063002: add keyword suggestions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analysis_server/tool/spec/spec_input.html ('K') | « pkg/analysis_services/lib/completion/completion_suggestion.dart ('k') | pkg/analysis_services/lib/src/completion/keyword_computer.dart » ('j') | pkg/analysis_services/lib/src/completion/keyword_computer.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_services/lib/src/completion/dart_completion_manager.dart

diff --git a/pkg/analysis_services/lib/src/completion/dart_completion_manager.dart b/pkg/analysis_services/lib/src/completion/dart_completion_manager.dart

index b179d947201904339ea95435b74339c4ca8477e4..4ddeb958f49719388a7b6da8a00a66e3530779ea 100644

--- a/pkg/analysis_services/lib/src/completion/dart_completion_manager.dart

+++ b/pkg/analysis_services/lib/src/completion/dart_completion_manager.dart

@@ -10,11 +10,12 @@ import 'package:analysis_services/completion/completion_computer.dart';

import 'package:analysis_services/completion/completion_suggestion.dart';

import 'package:analysis_services/search/search_engine.dart';

import 'package:analysis_services/src/completion/imported_type_computer.dart';

+import 'package:analysis_services/src/completion/keyword_computer.dart';

+import 'package:analysis_services/src/completion/local_computer.dart';

import 'package:analyzer/src/generated/ast.dart';

import 'package:analyzer/src/generated/element.dart';

import 'package:analyzer/src/generated/engine.dart';

import 'package:analyzer/src/generated/source.dart';

-import 'package:analysis_services/src/completion/local_computer.dart';

/**

* Manages code completion for a given Dart file completion request.

@@ -78,7 +79,10 @@ class DartCompletionManager extends CompletionManager {

void initComputers() {

if (computers == null) {

- computers = [new LocalComputer(), new ImportedTypeComputer()];

+ computers = [

+ new KeywordComputer(),

+ new LocalComputer(),

+ new ImportedTypeComputer()];

}

computers.forEach((CompletionComputer c) {

c.context = context;