tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py - Issue 461043003: Implement --browser=<perf trybot>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py

Issue 461043003: Implement --browser=<perf trybot> (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merged with dependent CLS Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py ('k') | tools/telemetry/telemetry/core/backends/remote/__init__.py » ('j') | tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py b/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py

index 90128ce505f3f8e93af9b045dde2c229249c05f8..a310d30c1a87428816c0792cce821ab696d089dd 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py

@@ -68,9 +68,6 @@ class PossibleDesktopBrowser(possible_browser.PossibleBrowser):

return False

return True

- def UpdateExecutableIfNeeded(self):

- pass

def last_modification_time(self):

if os.path.exists(self._local_executable):

return os.path.getmtime(self._local_executable)