Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 461043002: Revert of SkImage_Codec is Lazy (Closed)

Created:
6 years, 4 months ago by hal.canary
Modified:
6 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of SkImage_Codec is Lazy (https://codereview.chromium.org/460823002/) Reason for revert: breaks chromium - no SkDecodingImageGenerator::Create Original issue's description: > SkImage_Codec is Lazy > > Committed: https://skia.googlesource.com/skia/+/e36f499110da8c2e2aa05227bee6deb967309ead TBR=reed@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/b2edec2c396f9be3e527179bd0e5c866b59ae795

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -20 lines) Patch
M gyp/core.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A src/image/SkImage_Codec.cpp View 1 chunk +80 lines, -0 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 3 chunks +0 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hal.canary
Created Revert of SkImage_Codec is Lazy
6 years, 4 months ago (2014-08-12 13:52:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/461043002/1
6 years, 4 months ago (2014-08-12 13:53:21 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 13:53:33 UTC) #3
Message was sent while issue was closed.
Change committed as b2edec2c396f9be3e527179bd0e5c866b59ae795

Powered by Google App Engine
This is Rietveld 408576698