Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 460983002: Oilpan: fix build after r180052. (Closed)

Created:
6 years, 4 months ago by sof
Modified:
6 years, 4 months ago
Reviewers:
haraken, oilpan-reviews
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix build after r180052. TBR=haraken,oilpan-reviews BUG=383813 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180061

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M Source/core/dom/FullscreenElementStack.h View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
Please take a look.
6 years, 4 months ago (2014-08-12 10:58:46 UTC) #1
haraken
LGTM
6 years, 4 months ago (2014-08-12 11:00:49 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 4 months ago (2014-08-12 11:02:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/460983002/1
6 years, 4 months ago (2014-08-12 11:02:16 UTC) #4
commit-bot: I haz the power
Change committed as 180061
6 years, 4 months ago (2014-08-12 11:02:38 UTC) #5
Fabrice (no longer in Chrome)
6 years, 4 months ago (2014-08-12 11:12:37 UTC) #6
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/461963002/ by fdegans@chromium.org.

The reason for reverting is: Android Builder failed to compile.

Powered by Google App Engine
This is Rietveld 408576698