Issue 460963002: Files.app: Add more unit tests for FileOperationManager class.

Issue 460963002: Files.app: Add more unit tests for FileOperationManager class. (Closed)

Created:
6 years, 4 months ago by hirono

Modified:
6 years, 4 months ago

Reviewers:
yoshiki

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Files.app: Add more unit tests for FileOperationManager class. The CL adds tests for * Copy * Delete * Zip operations of the class. BUG=315439 TEST=run the test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289622

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+416 lines, -121 lines)			Patch
	M	chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js	View	1 2 3	7 chunks	+280 lines, -90 lines	0 comments	Download
	M	chrome/test/data/file_manager/unit_tests/mocks/mock_entry.js	View	1	4 chunks	+136 lines, -31 lines	0 comments	Download

Total messages: 9 (0 generated)

hirono

PTAL the CL? To pass the unit test, needs fix crrev.com/466583003. Thank you!

6 years, 4 months ago (2014-08-13 06:28:48 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/460963002/140001

6 years, 4 months ago (2014-08-14 10:44:17 UTC) #7

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...

6 years, 4 months ago (2014-08-14 15:54:07 UTC) #8

commit-bot: I haz the power

6 years, 4 months ago (2014-08-14 17:12:46 UTC) #9

Message was sent while issue was closed.

Committed patchset #4 (140001) as 289622