Split Shell::ToggleAppList() into ShowAppList and DismissAppList.

ash/accelerators/accelerator_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/accelerators/accelerator_controller.h"
 
 #include <algorithm>
 #include <cmath>
 #include <string>
 
@@ skipping 467 matching lines @@
     return false;
   if (key_code == ui::VKEY_LWIN)
     base::RecordAction(base::UserMetricsAction("Accel_Search_LWin"));
   // When spoken feedback is enabled, we should neither toggle the list nor
   // consume the key since Search+Shift is one of the shortcuts the a11y
   // feature uses. crbug.com/132296
   DCHECK_EQ(ui::VKEY_LWIN, accelerator.key_code());
   if (Shell::GetInstance()->accessibility_delegate()->
       IsSpokenFeedbackEnabled())
     return false;
-  ash::Shell::GetInstance()->ToggleAppList(NULL);
+  if (ash::Shell::GetInstance()->GetAppListTargetVisibility())

[Matt Giuca, 2014/08/14 04:17:06]

I think it would be good to preserve ToggleAppList as a wrapper around
ShowAppList and DismissAppList, so you don't need this four-line logic
duplicated in potentially multiple places (I count 2 in this CL, but more may
follow).

[calamity, 2014/08/14 05:00:59]

Done.

+    ash::Shell::GetInstance()->DismissAppList();
+  else
+    ash::Shell::GetInstance()->ShowAppList(NULL);
   return true;
 }
 
 bool HandleToggleFullscreen(ui::KeyboardCode key_code) {
   if (key_code == ui::VKEY_MEDIA_LAUNCH_APP2) {
     base::RecordAction(UserMetricsAction("Accel_Fullscreen_F4"));
   }
   accelerators::ToggleFullscreen();
   return true;
 }
@@ skipping 703 matching lines @@
     keyboard_brightness_control_delegate) {
   keyboard_brightness_control_delegate_ =
       keyboard_brightness_control_delegate.Pass();
 }
 
 bool AcceleratorController::CanHandleAccelerators() const {
   return true;
 }
 
 }  // namespace ash