Source/bindings/tests/results/V8TestInterfaceConstructor.cpp - Issue 460923002: Decouple arity errors creation from throwing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterfaceConstructor.cpp

Issue 460923002: Decouple arity errors creation from throwing. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/tests/results/V8TestInterfaceConstructor.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfaceConstructor.cpp b/Source/bindings/tests/results/V8TestInterfaceConstructor.cpp

index c40094c1b16ec86ccf2bbfbe46f5c230590b39a1..d8bc6fb4304b6fa9673d9e365c6c561acc820c48 100644

--- a/Source/bindings/tests/results/V8TestInterfaceConstructor.cpp

+++ b/Source/bindings/tests/results/V8TestInterfaceConstructor.cpp

@@ -239,7 +239,8 @@ static void V8TestInterfaceConstructorConstructorCallback(const v8::FunctionCall

}

ExceptionState exceptionState(ExceptionState::ConstructionContext, "TestInterfaceConstructor", info.Holder(), info.GetIsolate());

if (UNLIKELY(info.Length() < 1)) {

- throwMinimumArityTypeError(exceptionState, 1, info.Length());

+ setMinimumArityTypeError(exceptionState, 1, info.Length());

+ exceptionState.throwIfNeeded();

return;

}

V8StringResource<> arg;