Source/bindings/modules/v8/custom/V8SubtleCryptoCustom.cpp - Issue 460923002: Decouple arity errors creation from throwing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/modules/v8/custom/V8SubtleCryptoCustom.cpp

Issue 460923002: Decouple arity errors creation from throwing. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/modules/v8/custom/V8SubtleCryptoCustom.cpp

diff --git a/Source/bindings/modules/v8/custom/V8SubtleCryptoCustom.cpp b/Source/bindings/modules/v8/custom/V8SubtleCryptoCustom.cpp

index e2e3beaa21c996842e0d1639752d5e486f890404..379dcd06928d26fe3466b23629ec82ec5b69c4f6 100644

--- a/Source/bindings/modules/v8/custom/V8SubtleCryptoCustom.cpp

+++ b/Source/bindings/modules/v8/custom/V8SubtleCryptoCustom.cpp

@@ -114,7 +114,8 @@ void V8SubtleCrypto::verifyMethodCustom(const v8::FunctionCallbackInfo<v8::Value

}

break;

default:

- throwArityTypeError(exceptionState, "[4]", info.Length());

+ setArityTypeError(exceptionState, "[4]", info.Length());

+ exceptionState.throwIfNeeded();

return;

break;

}