Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: Source/bindings/core/v8/custom/V8ElementCustom.cpp

Issue 460923002: Decouple arity errors creation from throwing. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 } 218 }
219 // [MeasureAs=ElementAnimateKeyframeListEffectDoubleTiming] 219 // [MeasureAs=ElementAnimateKeyframeListEffectDoubleTiming]
220 // AnimationPlayer animate(sequence<Dictionary> effect, double timing); 220 // AnimationPlayer animate(sequence<Dictionary> effect, double timing);
221 if (info[0]->IsArray()) { 221 if (info[0]->IsArray()) {
222 UseCounter::count(callingExecutionContext(isolate), UseCounter::Elem entAnimateKeyframeListEffectDoubleTiming); 222 UseCounter::count(callingExecutionContext(isolate), UseCounter::Elem entAnimateKeyframeListEffectDoubleTiming);
223 animate5Method(info); 223 animate5Method(info);
224 return; 224 return;
225 } 225 }
226 break; 226 break;
227 default: 227 default:
228 throwArityTypeError(exceptionState, "[1]", info.Length()); 228 setArityTypeError(exceptionState, "[1]", info.Length());
229 exceptionState.throwIfNeeded();
229 return; 230 return;
230 break; 231 break;
231 } 232 }
232 exceptionState.throwTypeError("No function was found that matched the signat ure provided."); 233 exceptionState.throwTypeError("No function was found that matched the signat ure provided.");
233 exceptionState.throwIfNeeded(); 234 exceptionState.throwIfNeeded();
234 } 235 }
235 236
236 } // namespace blink 237 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/V8Binding.cpp ('k') | Source/bindings/modules/v8/custom/V8SubtleCryptoCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698