Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: Source/core/rendering/compositing/CompositedLayerMapping.cpp

Issue 460883002: Non-composited scrolling div should invalidate when it has descendant paints to its backing (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebaseline Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderLayerScrollableArea.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2010, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2009, 2010, 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 if (!page) 154 if (!page)
155 return 0; 155 return 0;
156 156
157 return page->scrollingCoordinator(); 157 return page->scrollingCoordinator();
158 } 158 }
159 159
160 CompositedLayerMapping::CompositedLayerMapping(RenderLayer& layer) 160 CompositedLayerMapping::CompositedLayerMapping(RenderLayer& layer)
161 : m_owningLayer(layer) 161 : m_owningLayer(layer)
162 , m_pendingUpdateScope(GraphicsLayerUpdateNone) 162 , m_pendingUpdateScope(GraphicsLayerUpdateNone)
163 , m_isMainFrameRenderViewLayer(false) 163 , m_isMainFrameRenderViewLayer(false)
164 , m_requiresOwnBackingStoreForIntrinsicReasons(true) 164 , m_requiresOwnBackingStoreForIntrinsicReasons(false)
165 , m_requiresOwnBackingStoreForAncestorReasons(true) 165 , m_requiresOwnBackingStoreForAncestorReasons(false)
abarth-chromium 2014/08/14 03:54:54 This CL seems fine to me, but we should get vollic
Ian Vollick 2014/08/14 17:16:44 This seems fine to me. Using dirty bits here feels
166 , m_backgroundLayerPaintsFixedRootBackground(false) 166 , m_backgroundLayerPaintsFixedRootBackground(false)
167 , m_scrollingContentsAreEmpty(false) 167 , m_scrollingContentsAreEmpty(false)
168 { 168 {
169 if (layer.isRootLayer() && renderer()->frame()->isMainFrame()) 169 if (layer.isRootLayer() && renderer()->frame()->isMainFrame())
170 m_isMainFrameRenderViewLayer = true; 170 m_isMainFrameRenderViewLayer = true;
171 171
172 createPrimaryGraphicsLayer(); 172 createPrimaryGraphicsLayer();
173 } 173 }
174 174
175 CompositedLayerMapping::~CompositedLayerMapping() 175 CompositedLayerMapping::~CompositedLayerMapping()
(...skipping 2111 matching lines...) Expand 10 before | Expand all | Expand 10 after
2287 } else if (graphicsLayer == m_scrollingBlockSelectionLayer.get()) { 2287 } else if (graphicsLayer == m_scrollingBlockSelectionLayer.get()) {
2288 name = "Scrolling Block Selection Layer"; 2288 name = "Scrolling Block Selection Layer";
2289 } else { 2289 } else {
2290 ASSERT_NOT_REACHED(); 2290 ASSERT_NOT_REACHED();
2291 } 2291 }
2292 2292
2293 return name; 2293 return name;
2294 } 2294 }
2295 2295
2296 } // namespace blink 2296 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderLayerScrollableArea.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698