Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 460863002: Rename Node to View in the View Manager mojom & client lib. Service TBD. (Closed)

Created:
6 years, 4 months ago by Ben Goodger (Google)
Modified:
6 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Rename Node to View in the View Manager mojom & client lib. Service TBD. TBR=sky@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288987

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1748 lines, -2373 lines) Patch
M mojo/aura/window_tree_host_mojo.h View 3 chunks +7 lines, -7 lines 0 comments Download
M mojo/aura/window_tree_host_mojo.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M mojo/examples/aura_demo/aura_demo.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/examples/browser/browser.cc View 11 chunks +23 lines, -23 lines 0 comments Download
M mojo/examples/embedded_app/embedded_app.cc View 7 chunks +26 lines, -26 lines 0 comments Download
M mojo/examples/keyboard/keyboard.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M mojo/examples/media_viewer/media_viewer.cc View 11 chunks +43 lines, -43 lines 0 comments Download
M mojo/examples/nesting_app/nesting_app.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M mojo/examples/png_viewer/png_viewer.cc View 9 chunks +17 lines, -17 lines 0 comments Download
M mojo/examples/window_manager/debug_panel.h View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/examples/window_manager/debug_panel.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M mojo/examples/window_manager/window_manager.cc View 19 chunks +132 lines, -132 lines 0 comments Download
M mojo/examples/wm_flow/app/app.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/examples/wm_flow/embedded/embedded.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/examples/wm_flow/wm/wm.cc View 3 chunks +9 lines, -10 lines 0 comments Download
M mojo/mojo_services.gypi View 2 chunks +6 lines, -7 lines 0 comments Download
M mojo/services/html_viewer/html_document_view.h View 3 chunks +8 lines, -9 lines 0 comments Download
M mojo/services/html_viewer/html_document_view.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M mojo/services/html_viewer/html_viewer.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M mojo/services/public/cpp/view_manager/BUILD.gn View 1 chunk +6 lines, -6 lines 0 comments Download
D mojo/services/public/cpp/view_manager/lib/node.cc View 1 chunk +0 lines, -387 lines 0 comments Download
D mojo/services/public/cpp/view_manager/lib/node_observer.cc View 1 chunk +0 lines, -20 lines 0 comments Download
D mojo/services/public/cpp/view_manager/lib/node_private.h View 1 chunk +0 lines, -57 lines 0 comments Download
D mojo/services/public/cpp/view_manager/lib/node_private.cc View 1 chunk +0 lines, -21 lines 0 comments Download
A + mojo/services/public/cpp/view_manager/lib/view.cc View 11 chunks +108 lines, -108 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h View 5 chunks +35 lines, -35 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc View 10 chunks +130 lines, -130 lines 0 comments Download
A + mojo/services/public/cpp/view_manager/lib/view_observer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A mojo/services/public/cpp/view_manager/lib/view_private.h View 1 chunk +57 lines, -0 lines 0 comments Download
A + mojo/services/public/cpp/view_manager/lib/view_private.cc View 1 chunk +6 lines, -6 lines 0 comments Download
D mojo/services/public/cpp/view_manager/node.h View 1 chunk +0 lines, -117 lines 0 comments Download
D mojo/services/public/cpp/view_manager/node_observer.h View 1 chunk +0 lines, -74 lines 0 comments Download
D mojo/services/public/cpp/view_manager/tests/node_unittest.cc View 1 chunk +0 lines, -544 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc View 11 chunks +169 lines, -169 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_unittest.cc View 1 chunk +544 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/types.h View 1 chunk +4 lines, -4 lines 0 comments Download
A + mojo/services/public/cpp/view_manager/view.h View 4 chunks +32 lines, -32 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view_manager.h View 2 chunks +8 lines, -8 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view_manager_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
A + mojo/services/public/cpp/view_manager/view_observer.h View 2 chunks +24 lines, -25 lines 0 comments Download
M mojo/services/public/cpp/view_manager/window_manager_delegate.h View 1 chunk +5 lines, -5 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 3 chunks +84 lines, -84 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/test_change_tracker.h View 3 chunks +5 lines, -5 lines 0 comments Download
M mojo/services/view_manager/test_change_tracker.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.h View 1 chunk +19 lines, -20 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.cc View 21 chunks +57 lines, -58 lines 0 comments Download
M mojo/services/view_manager/view_manager_unittest.cc View 12 chunks +19 lines, -19 lines 0 comments Download
M mojo/services/window_manager/window_manager_api_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M mojo/services/window_manager/window_manager_app.h View 7 chunks +16 lines, -16 lines 0 comments Download
M mojo/services/window_manager/window_manager_app.cc View 9 chunks +43 lines, -44 lines 0 comments Download
M mojo/services/window_manager/window_manager_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/window_manager/window_manager_service_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/views/native_widget_view_manager.h View 4 chunks +8 lines, -8 lines 0 comments Download
M mojo/views/native_widget_view_manager.cc View 3 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
6 years, 4 months ago (2014-08-11 23:16:53 UTC) #1
Ben Goodger (Google)
6 years, 4 months ago (2014-08-12 15:43:39 UTC) #2
Message was sent while issue was closed. 
Committed patchset #2 manually as 288987 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698