tools/metrics/histograms/histograms.xml - Issue 460843002: metrics: Document ownership of Power.* histograms.

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 460843002: metrics: Document ownership of Power.* histograms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 3cece98cc73dc8aa64b4555f41bd7e4125cd3d84..1f07600a23eab1083a312a9744e08bd27f03761c 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -22786,7 +22786,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

The level of the backlight as a percentage when the user is on AC. Sampled

every 30 seconds.

@@ -22794,7 +22794,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

The level of the backlight as a percentage when the user is on battery.

Sampled every 30 seconds.

@@ -22802,7 +22802,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

Chrome OS battery charge health percentage. Sampled once when device starts

charging.

@@ -22829,7 +22829,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

Counts the number of times we have read the battery status from sysfs and if

it gave us sensible values.

@@ -22837,7 +22837,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

Chrome OS remaining battery charge as percent of the maximum battery charge,

sampled at the end of a user session when the device is on AC.

@@ -22845,7 +22845,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

Chrome OS remaining battery charge as percent of the maximum battery charge,

sampled at the end of a user session when the device is on battery.

@@ -22853,7 +22853,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

Chrome OS remaining battery charge as percent of the maximum battery charge,

sampled at the start of a user session when the device is on AC.

@@ -22861,7 +22861,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

Chrome OS remaining battery charge as percent of the maximum battery charge,

sampled at the start of a user session when the device is on battery.

@@ -22872,7 +22872,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

Deprecated as of 03/2012, no longer being generated by powerd.

</obsolete>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

Chrome OS remaining battery charge as percent of the maximum battery charge

sampled when the device runs on battery.

@@ -22880,7 +22880,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

Chrome OS remaining battery charge as percent of the maximum battery charge,

sampled when charging starts.

@@ -22891,7 +22891,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

Deprecated as of 03/2012, no longer being generated by powerd.

</obsolete>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

Chrome OS remaining time to empty battery in minutes sampled when the device

runs on battery.

@@ -22899,7 +22899,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>dianders@chromium.org</owner>

Chrome OS (Snow RO firmware 2695.90.0 only) number of 8K chunks that were

fixed (memory corruption corrected) for each suspend/resume cycle. Expect 0

@@ -22908,7 +22908,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>dianders@chromium.org</owner>

Chrome OS (Snow RO firmware 2695.90.0 only) number of 4-byte words that were

fixed (memory corruption corrected) for each suspend/resume cycle. Expect 0

@@ -22923,7 +22923,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

Deprecated as of 5/2013. See Accel_BrightnessDown_F6 and

Accel_BrightnessUp_F7 user actions instead.

</obsolete>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

Number of times the user has adjusted brightness up and down while running

on battery power.

@@ -22935,7 +22935,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

Deprecated as of 5/2013. See Accel_BrightnessDown_F6 and

Accel_BrightnessUp_F7 user actions instead.

</obsolete>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

Number of times the user has adjusted brightness up and down while running

on AC power.

@@ -22943,7 +22943,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

External power supply type such as MAINS_CHARGER, USB_CHARGER,

UNCONFIRMED_SPRING_CHARGER, SAFE_SPRING_CHARGER. A sample is reported each

@@ -22953,7 +22953,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

<histogram name="Power.ExternalBrightnessReadResult"

enum="ExternalDisplayReceiveResult">

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

The result of attempting to read an external display's brightness on Chrome

OS. A read attempt is made after successfully requesting the brightness (see

@@ -22963,7 +22963,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

<histogram name="Power.ExternalBrightnessRequestResult"

enum="ExternalDisplaySendResult">

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

The result of requesting an external display's brightness on Chrome OS. A

request is sent when the user presses a brightness key and the current

@@ -22974,7 +22974,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

<histogram name="Power.ExternalBrightnessWriteResult"

enum="ExternalDisplaySendResult">

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

The result of attempting to change an external display's brightness on

Chrome OS. A request is sent when the user presses a brightness key and the

@@ -22984,7 +22984,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

<histogram name="Power.ExternalDisplayOpenResult"

enum="ExternalDisplayOpenResult">

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

The result of attempting to open an I2C device to control an external

display's brightness on Chrome OS. An attempt is made when a display is

@@ -22993,7 +22993,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>snanda@chromium.org</owner>

The time that the firmware took to resume the Chrome OS device from

suspend-to-RAM state when running on AC at pre-suspend time.

@@ -23001,7 +23001,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>snanda@chromium.org</owner>

The time that the firmware took to resume the Chrome OS device from

suspend-to-RAM state when running on battery at pre-suspend time.

@@ -23009,7 +23009,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

Chrome OS user idle time since the screen dimmed sampled when the user

becomes active again if the device runs on AC.

@@ -23017,7 +23017,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

Chrome OS user idle time since the screen dimmed sampled when the user

becomes active again if the device runs on battery.

@@ -23025,7 +23025,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

Chrome OS user idle time since the screen turned off sampled when the user

becomes active again if the device runs on AC.

@@ -23033,7 +23033,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

Chrome OS user idle time since the screen turned off sampled when the user

becomes active again if the device runs on battery.

@@ -23041,7 +23041,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

Chrome OS user idle time sampled when the user becomes active again if the

device runs on AC.

@@ -23049,7 +23049,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

Chrome OS user idle time sampled when the user becomes active again if the

device runs on battery.

@@ -23057,7 +23057,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>snanda@chromium.org</owner>

The time that the kernel took to resume the Chrome OS device from

suspend-to-RAM state when running on AC at pre-suspend time.

@@ -23065,7 +23065,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>snanda@chromium.org</owner>

The time that the kernel took to resume the Chrome OS device from

suspend-to-RAM state when running on battery at pre-suspend time.

@@ -23073,7 +23073,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>snanda@chromium.org</owner>

The time that the kernel took to suspend-to-RAM the Chrome OS device when

running on AC.

@@ -23081,7 +23081,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>snanda@chromium.org</owner>

The time that the kernel took to suspend-to-RAM the Chrome OS device when

running on battery.

@@ -23097,7 +23097,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

The length of time, in seconds, that a user spent in a single session.

Values for this metric are clamped to 12 hours, so the last bucket should be

@@ -23164,7 +23164,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

The number of user sessions that occured since the last time that the device

was charged. Values for this metric are clamped at 10k, so the last bucket

@@ -23194,7 +23194,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

Deprecated Feb 2014 by Power.SuspendAttemptsBeforeCancel and

Power.SuspendAttemptsBeforeSuccess.

</obsolete>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

The number of times Chrome OS retried suspend due to previous failure.

</summary>

@@ -23209,7 +23209,8 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

+ <owner>snanda@chromium.org</owner>

The number of suspend attempts on Chrome OS. Samples are reported before

each attempt, so this histogram may include cases where the system crashed

@@ -23219,6 +23220,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

<owner>derat@chromium.org</owner>

+ <owner>snanda@chromium.org</owner>

The number of suspend attempts performed for a single suspend request (e.g.

triggered by the lid being closed) that was eventually canceled on Chrome

@@ -23229,6 +23231,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

<owner>derat@chromium.org</owner>

+ <owner>snanda@chromium.org</owner>

The number of suspend attempts performed for a single suspend request (e.g.

triggered by the lid being closed) that eventually succeeded on Chrome OS.

@@ -23237,7 +23240,8 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

+ <owner>snanda@chromium.org</owner>

The results of suspend attempts on Chrome OS. Samples are reported after

each attempt.

@@ -23248,12 +23252,15 @@ Therefore, the affected-histogram name has to have at least one dot in it.

Deprecated Jan 2014 by Power.SuspendAttempt and Power.SuspendResult.

</obsolete>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

<summary>Chrome OS suspend status.</summary>

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <obsolete>

+ No longer sent.

+ </obsolete>

+ <owner>derat@chromium.org</owner>

The percentage of aborted fan attempts out of total fan attempts per

session, where an abort is due to hysteresis. This value is computed from

@@ -23262,7 +23269,10 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <obsolete>

+ No longer sent.

+ </obsolete>

+ <owner>derat@chromium.org</owner>

The percentage of fan trip point passes that are more than one trip point.

This value is computed from boot and sent when powerd starts and then every

@@ -23271,7 +23281,8 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

+ <owner>snanda@chromium.org</owner>

Chrome OS time in minutes spent in suspend-to-RAM mode sampled at boot

(i.e., the device most likely ran out of battery while in suspend).

@@ -23279,7 +23290,8 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>derat@chromium.org</owner>

+ <owner>snanda@chromium.org</owner>

Chrome OS time in minutes spent in suspend-to-RAM mode sampled at resume.

</summary>

« no previous file with comments | « no previous file | no next file » | no next file with comments »