Refresh Public Suffix List to the latest version

Refresh Public Suffix List to the latest version

This updates to the following revision: aedf1212d667 2014-08-05 11:00 -0400

It includes changes from revision 131f3403a484 (2014-06-12 07:56 -0400) to
revision aedf1212d667 (2014-08-05 11:00 -0400), listed at
http://hg.mozilla.org/mozilla-central/log/aedf1212d667/netwerk/dns/effective_tld_names.dat

R=pkasting@chromium.org
BUG=37436
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288965

[Ryan Sleevi, 2014-08-11 21:48:13]

*sigh*cann.

Latest update. With .nexus, .google, and .chrome

[Peter Kasting, 2014-08-11 21:56:14]

https://codereview.chromium.org/460833002/diff/1/net/base/registry_controlled...
File net/base/registry_controlled_domains/effective_tld_names.dat (right):

https://codereview.chromium.org/460833002/diff/1/net/base/registry_controlled...
net/base/registry_controlled_domains/effective_tld_names.dat:7999: xn--30rr7y
These sorts of entries are represented above with the actual IDNs, but here
they're in punycode.  Please be consistent.  (I'd prefer the IDNs.)

[Ryan Sleevi, 2014-08-11 22:04:57]

On 2014/08/11 21:56:14, Peter Kasting wrote:
>
https://codereview.chromium.org/460833002/diff/1/net/base/registry_controlled...
> File net/base/registry_controlled_domains/effective_tld_names.dat (right):
> 
>
https://codereview.chromium.org/460833002/diff/1/net/base/registry_controlled...
> net/base/registry_controlled_domains/effective_tld_names.dat:7999: xn--30rr7y
> These sorts of entries are represented above with the actual IDNs, but here
> they're in punycode.  Please be consistent.  (I'd prefer the IDNs.)

Upstream already has the bug filed for this. This is the upstream data file.

[Peter Kasting, 2014-08-11 22:06:57]

On 2014/08/11 22:04:57, Ryan Sleevi wrote:
> On 2014/08/11 21:56:14, Peter Kasting wrote:
> >
>
https://codereview.chromium.org/460833002/diff/1/net/base/registry_controlled...
> > File net/base/registry_controlled_domains/effective_tld_names.dat (right):
> > 
> >
>
https://codereview.chromium.org/460833002/diff/1/net/base/registry_controlled...
> > net/base/registry_controlled_domains/effective_tld_names.dat:7999:
xn--30rr7y
> > These sorts of entries are represented above with the actual IDNs, but here
> > they're in punycode.  Please be consistent.  (I'd prefer the IDNs.)
> 
> Upstream already has the bug filed for this. This is the upstream data file.

Does it have any practical effect?  Or do the two result in exactly the same
memory footprint, performance, etc?

LGTM I guess, but I'd really prefer to land a version that fixes this
inconsistency...

[Ryan Sleevi, 2014-08-11 22:13:17]

On 2014/08/11 22:06:57, Peter Kasting wrote:
> On 2014/08/11 22:04:57, Ryan Sleevi wrote:
> > On 2014/08/11 21:56:14, Peter Kasting wrote:
> > >
> >
>
https://codereview.chromium.org/460833002/diff/1/net/base/registry_controlled...
> > > File net/base/registry_controlled_domains/effective_tld_names.dat (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/460833002/diff/1/net/base/registry_controlled...
> > > net/base/registry_controlled_domains/effective_tld_names.dat:7999:
> xn--30rr7y
> > > These sorts of entries are represented above with the actual IDNs, but
here
> > > they're in punycode.  Please be consistent.  (I'd prefer the IDNs.)
> > 
> > Upstream already has the bug filed for this. This is the upstream data file.
> 
> Does it have any practical effect?  Or do the two result in exactly the same
> memory footprint, performance, etc?
> 
> LGTM I guess, but I'd really prefer to land a version that fixes this
> inconsistency...

The same. The gperf is the authoritative file, and tld_cleanup punycodes the
names that need em.

[Ryan Sleevi, 2014-08-11 23:27:05]

Blergh, sorry to kick it back to you to review again. Looks like .google broke a
test in component_unittests (one of the ones I didn't run locally), so there's a
fix there. And adding myself to OWNERS

[Peter Kasting, 2014-08-12 00:52:09]

LGTM

[Ryan Sleevi, 2014-08-12 00:53:16]

The CQ bit was checked by rsleevi@chromium.org

[commit-bot: I haz the power, 2014-08-12 01:04:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rsleevi@chromium.org/460833002/20001

[commit-bot: I haz the power, 2014-08-12 08:13:29]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[commit-bot: I haz the power, 2014-08-12 14:49:29]

Change committed as 288965