Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 460823002: SkImage_Codec is Lazy (Closed)

Created:
6 years, 4 months ago by hal.canary
Modified:
6 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 : big refactor #

Total comments: 1

Patch Set 2 : simplest possible change #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -81 lines) Patch
M gyp/core.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D src/image/SkImage_Codec.cpp View 1 chunk +0 lines, -80 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 1 3 chunks +19 lines, -0 lines 1 comment Download

Messages

Total messages: 14 (0 generated)
hal.canary
ptal
6 years, 4 months ago (2014-08-11 21:02:47 UTC) #1
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 4 months ago (2014-08-11 21:12:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/460823002/20001
6 years, 4 months ago (2014-08-11 21:13:35 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-11 21:13:36 UTC) #4
reed1
https://codereview.chromium.org/460823002/diff/20001/src/image/SkImage_Raster.cpp File src/image/SkImage_Raster.cpp (right): https://codereview.chromium.org/460823002/diff/20001/src/image/SkImage_Raster.cpp#newcode158 src/image/SkImage_Raster.cpp:158: SkASSERT(data.get()); assert not needed, we will crash if NewWithCopy ...
6 years, 4 months ago (2014-08-11 21:14:08 UTC) #5
hal.canary
The CQ bit was unchecked by halcanary@google.com
6 years, 4 months ago (2014-08-11 21:15:57 UTC) #6
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 4 months ago (2014-08-11 21:25:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/460823002/40001
6 years, 4 months ago (2014-08-11 21:25:32 UTC) #8
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-11 21:25:34 UTC) #9
hal.canary
please take another look
6 years, 4 months ago (2014-08-11 21:25:44 UTC) #10
hal.canary
The CQ bit was unchecked by halcanary@google.com
6 years, 4 months ago (2014-08-11 21:32:23 UTC) #11
reed1
lgtm https://codereview.chromium.org/460823002/diff/40001/src/image/SkImage_Raster.cpp File src/image/SkImage_Raster.cpp (right): https://codereview.chromium.org/460823002/diff/40001/src/image/SkImage_Raster.cpp#newcode74 src/image/SkImage_Raster.cpp:74: :INHERITED(bitmap.width(), bitmap.height()) tiny nit: space after :
6 years, 4 months ago (2014-08-12 13:36:09 UTC) #12
commit-bot: I haz the power
Change committed as e36f499110da8c2e2aa05227bee6deb967309ead
6 years, 4 months ago (2014-08-12 13:37:26 UTC) #13
hal.canary
6 years, 4 months ago (2014-08-12 13:52:52 UTC) #14
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/461043002/ by halcanary@google.com.

The reason for reverting is: breaks chromium - no
SkDecodingImageGenerator::Create.

Powered by Google App Engine
This is Rietveld 408576698