Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 46076: Removed zombie hunter code (Closed)

Created:
11 years, 9 months ago by Xharze
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Removed zombie hunter code BUG=6468

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -63 lines) Patch
M chrome/browser/process_singleton.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/process_singleton_linux.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/process_singleton_win.cc View 1 1 chunk +0 lines, -54 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Xharze
11 years, 9 months ago (2009-03-14 02:24:55 UTC) #1
Mark Larson
+cc maruel, deanm: They've been looking at this bug, so they might be the best ...
11 years, 9 months ago (2009-03-14 05:44:34 UTC) #2
Xharze
Ok thanks, I'll wait for feedback from them
11 years, 9 months ago (2009-03-15 23:38:00 UTC) #3
M-A Ruel
This change fails on Linux: browser/process_singleton_linux.cc:58: error: no 'void ProcessSingleton::HuntForZombieChromeProcesses()' member function declared in class ...
11 years, 9 months ago (2009-03-16 15:12:32 UTC) #4
M-A Ruel
Removed other reviewers.
11 years, 9 months ago (2009-03-16 15:13:04 UTC) #5
Xharze
Sorry did not see the process_singleton_linux.cc as it isn't part of the Visual Studio solution. ...
11 years, 9 months ago (2009-03-16 22:27:00 UTC) #6
Xharze
If there arn't any further comments, could you please commit the changes?
11 years, 9 months ago (2009-03-21 00:08:13 UTC) #7
M-A Ruel
On 2009/03/21 00:08:13, Xharze wrote: > If there arn't any further comments, could you please ...
11 years, 9 months ago (2009-03-23 21:24:54 UTC) #8
Xharze
11 years, 9 months ago (2009-03-24 19:18:42 UTC) #9
No problem

Powered by Google App Engine
This is Rietveld 408576698