Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 460743004: Improve audible token detection. (Closed)

Created:
6 years, 4 months ago by rkc
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Improve audible token detection. The current code doesn't differentiate between tokens decoded by the DSSS (inaudible) or DTMF (audible) encoder/decoder. Fix this and send up the correct medium to the server. R=kalman@chromium.org, xiyuan@chromium.org BUG=402334 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288872

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -37 lines) Patch
M chrome/browser/copresence/chrome_whispernet_client_browsertest.cc View 6 chunks +12 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/copresence_private/copresence_private_api.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/resources/whispernet_proxy/js/wrapper.js View 1 3 chunks +11 lines, -5 lines 0 comments Download
M chrome/browser/resources/whispernet_proxy/whispernet_proxy_pnacl.pexe.png View Binary file 0 comments Download
M chrome/common/extensions/api/copresence_private.idl View 1 chunk +7 lines, -2 lines 0 comments Download
M components/copresence/handlers/audio/audio_directive_handler_unittest.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M components/copresence/handlers/audio/audio_directive_list.h View 2 chunks +4 lines, -2 lines 0 comments Download
M components/copresence/handlers/audio/audio_directive_list.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/copresence/handlers/audio/audio_directive_list_unittest.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M components/copresence/public/whispernet_client.h View 2 chunks +11 lines, -3 lines 0 comments Download
M components/copresence/rpc/rpc_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M components/copresence/rpc/rpc_handler.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M components/copresence/rpc/rpc_handler_unittest.cc View 1 2 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
rkc
6 years, 4 months ago (2014-08-11 19:33:04 UTC) #1
not at google - send to devlin
extensions lgtm
6 years, 4 months ago (2014-08-11 19:52:55 UTC) #2
xiyuan
lgtm https://codereview.chromium.org/460743004/diff/1/chrome/browser/resources/whispernet_proxy/js/wrapper.js File chrome/browser/resources/whispernet_proxy/js/wrapper.js (right): https://codereview.chromium.org/460743004/diff/1/chrome/browser/resources/whispernet_proxy/js/wrapper.js#newcode193 chrome/browser/resources/whispernet_proxy/js/wrapper.js:193: * decoder or not. nit: 4-space indent (aligned ...
6 years, 4 months ago (2014-08-11 19:58:21 UTC) #3
rkc
https://codereview.chromium.org/460743004/diff/1/chrome/browser/resources/whispernet_proxy/js/wrapper.js File chrome/browser/resources/whispernet_proxy/js/wrapper.js (right): https://codereview.chromium.org/460743004/diff/1/chrome/browser/resources/whispernet_proxy/js/wrapper.js#newcode193 chrome/browser/resources/whispernet_proxy/js/wrapper.js:193: * decoder or not. On 2014/08/11 19:58:21, xiyuan wrote: ...
6 years, 4 months ago (2014-08-11 20:12:21 UTC) #4
rkc
The CQ bit was checked by rkc@chromium.org
6 years, 4 months ago (2014-08-11 20:12:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/460743004/20001
6 years, 4 months ago (2014-08-11 20:14:21 UTC) #6
xiyuan
You might need to manually land "whispernet_proxy_pnacl.pexe.png" since it's a binary file.
6 years, 4 months ago (2014-08-11 20:17:28 UTC) #7
rkc
On 2014/08/11 20:17:28, xiyuan wrote: > You might need to manually land "whispernet_proxy_pnacl.pexe.png" since it's ...
6 years, 4 months ago (2014-08-11 20:34:44 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-11 21:35:41 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-11 21:44:13 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/1943)
6 years, 4 months ago (2014-08-11 21:44:15 UTC) #11
rkc
The CQ bit was checked by rkc@chromium.org
6 years, 4 months ago (2014-08-11 22:23:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/460743004/40001
6 years, 4 months ago (2014-08-11 22:28:35 UTC) #13
rkc
6 years, 4 months ago (2014-08-12 01:59:00 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 manually as 288872 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698