Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: Source/core/inspector/InspectorConsoleMessage.h

Issue 460743003: [DevTools] Changed checks in InspectorConsoleWindow::autogenerateMetadata (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@remove-script-state-from-stack-factory
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorConsoleAgent.cpp ('k') | Source/core/inspector/InspectorConsoleMessage.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorConsoleMessage.h
diff --git a/Source/core/inspector/InspectorConsoleMessage.h b/Source/core/inspector/InspectorConsoleMessage.h
index 2285fdf4614ebdf0ad4ed453d0859bafeef0f1d6..ee5f839dcdef741c02ace361b06f0113a67a4265 100644
--- a/Source/core/inspector/InspectorConsoleMessage.h
+++ b/Source/core/inspector/InspectorConsoleMessage.h
@@ -50,10 +50,10 @@ class ScriptValue;
class InspectorConsoleMessage {
WTF_MAKE_NONCOPYABLE(InspectorConsoleMessage); WTF_MAKE_FAST_ALLOCATED;
public:
- InspectorConsoleMessage(bool canGenerateCallStack, MessageSource, MessageType, MessageLevel, const String& message);
- InspectorConsoleMessage(bool canGenerateCallStack, MessageSource, MessageType, MessageLevel, const String& message, const String& url, unsigned line, unsigned column, ScriptState*, unsigned long requestIdentifier);
+ InspectorConsoleMessage(MessageSource, MessageType, MessageLevel, const String& message);
+ InspectorConsoleMessage(bool shouldGenerateCallStack, MessageSource, MessageType, MessageLevel, const String& message, const String& url, unsigned line, unsigned column, ScriptState*, unsigned long requestIdentifier);
InspectorConsoleMessage(MessageSource, MessageType, MessageLevel, const String& message, PassRefPtrWillBeRawPtr<ScriptCallStack>, unsigned long requestIdentifier);
- InspectorConsoleMessage(bool canGenerateCallStack, MessageSource, MessageType, MessageLevel, const String& message, PassRefPtrWillBeRawPtr<ScriptArguments>, ScriptState*, unsigned long requestIdentifier);
+ InspectorConsoleMessage(MessageSource, MessageType, MessageLevel, const String& message, PassRefPtrWillBeRawPtr<ScriptArguments>, ScriptState*, unsigned long requestIdentifier);
~InspectorConsoleMessage();
void addToFrontend(InspectorFrontend::Console*, InjectedScriptManager*, bool generatePreview);
@@ -66,7 +66,7 @@ public:
unsigned argumentCount();
private:
- void autogenerateMetadata(bool canGenerateCallStack, ScriptState* = 0);
+ void autogenerateMetadata(bool shouldGenerateCallStack = true);
MessageSource m_source;
MessageType m_type;
« no previous file with comments | « Source/core/inspector/InspectorConsoleAgent.cpp ('k') | Source/core/inspector/InspectorConsoleMessage.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698