Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 460713002: DOMMatrix should use TransformationMatrix internally. (Closed)

Created:
6 years, 4 months ago by zino
Modified:
6 years, 4 months ago
Reviewers:
pdr., krit, Rik
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DOMMatrix should use TransformationMatrix internally. BUG=388780 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180399

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -83 lines) Patch
M Source/core/dom/DOMMatrix.h View 1 chunk +24 lines, -28 lines 0 comments Download
M Source/core/dom/DOMMatrix.cpp View 1 1 chunk +4 lines, -27 lines 0 comments Download
M Source/core/dom/DOMMatrixReadOnly.h View 1 chunk +27 lines, -24 lines 0 comments Download
M Source/core/dom/DOMMatrixReadOnly.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
zino
PTAL. To address Dirk's comments in other CLs, this CL should be landed first.
6 years, 4 months ago (2014-08-11 15:15:32 UTC) #1
zino
On 2014/08/11 15:15:32, zino wrote: > PTAL. > > To address Dirk's comments in other ...
6 years, 4 months ago (2014-08-14 10:51:12 UTC) #2
Rik
lgtm
6 years, 4 months ago (2014-08-14 15:27:53 UTC) #3
zino
Dear @pdr, Could you please review? (This CL needs owner's approval for landing.)
6 years, 4 months ago (2014-08-15 04:57:22 UTC) #4
krit
lgtm
6 years, 4 months ago (2014-08-15 16:20:50 UTC) #5
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 4 months ago (2014-08-15 23:43:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/460713002/20001
6 years, 4 months ago (2014-08-15 23:44:16 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-16 00:51:43 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-16 01:15:32 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (20001) as 180399

Powered by Google App Engine
This is Rietveld 408576698