DevTools: Decouple AdvancedApp from Toolbox

DevTools: Decouple AdvancedApp from Toolbox

This is required to introduce a new "toolbox" application
within the new application loading scheme.

R=dgozman, pfeldman, vsevik
BUG=391566
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180178

[apavlov, 2014-08-11 17:47:16]

https://codereview.chromium.org/460673003/diff/1/Source/devtools/front_end/to...
File Source/devtools/front_end/toolbox/ToolboxDelegate.js (right):

https://codereview.chromium.org/460673003/diff/1/Source/devtools/front_end/to...
Source/devtools/front_end/toolbox/ToolboxDelegate.js:8:
WebInspector.ToolboxDelegate = function() {}
This interface is required to reside out of "main", since the toolbox
application bootstrap loader will live in a new module not depending on "main".

[dgozman, 2014-08-12 16:30:39]

https://codereview.chromium.org/460673003/diff/1/Source/devtools/front_end/ma...
File Source/devtools/front_end/main/Toolbox.js (right):

https://codereview.chromium.org/460673003/diff/1/Source/devtools/front_end/ma...
Source/devtools/front_end/main/Toolbox.js:31: var advancedApp = /** @type
{!WebInspector.ToolboxDelegate} */ (window.opener.WebInspector["app"]);
advancedApp -> delegate?

https://codereview.chromium.org/460673003/diff/1/Source/devtools/front_end/to...
File Source/devtools/front_end/toolbox/ToolboxDelegate.js (right):

https://codereview.chromium.org/460673003/diff/1/Source/devtools/front_end/to...
Source/devtools/front_end/toolbox/ToolboxDelegate.js:15:
onSetInspectedPageBounds: function(toolbox, event) {},
I'd remove this and add |inspectedPagePlaceholder| parameter to toolboxLoaded
method.

[apavlov, 2014-08-12 17:58:24]

https://codereview.chromium.org/460673003/diff/1/Source/devtools/front_end/ma...
File Source/devtools/front_end/main/Toolbox.js (right):

https://codereview.chromium.org/460673003/diff/1/Source/devtools/front_end/ma...
Source/devtools/front_end/main/Toolbox.js:31: var advancedApp = /** @type
{!WebInspector.ToolboxDelegate} */ (window.opener.WebInspector["app"]);
On 2014/08/12 16:30:38, dgozman wrote:
> advancedApp -> delegate?

Done.

https://codereview.chromium.org/460673003/diff/1/Source/devtools/front_end/to...
File Source/devtools/front_end/toolbox/ToolboxDelegate.js (right):

https://codereview.chromium.org/460673003/diff/1/Source/devtools/front_end/to...
Source/devtools/front_end/toolbox/ToolboxDelegate.js:15:
onSetInspectedPageBounds: function(toolbox, event) {},
On 2014/08/12 16:30:38, dgozman wrote:
> I'd remove this and add |inspectedPagePlaceholder| parameter to toolboxLoaded
> method.

Done.

[dgozman, 2014-08-13 13:47:33]

https://codereview.chromium.org/460673003/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/main/Toolbox.js (right):

https://codereview.chromium.org/460673003/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/main/Toolbox.js:31: var delegate = /** @type
{!WebInspector.ToolboxDelegate} */ (window.opener.WebInspector["app"]);
Now that we are casting here, we can just
|window.opener.WebInspector["app"].toolboxLoaded(....)| and don't bother with
ToolboxDelegate. WDYT?

[apavlov, 2014-08-13 13:50:28]

https://codereview.chromium.org/460673003/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/main/Toolbox.js (right):

https://codereview.chromium.org/460673003/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/main/Toolbox.js:31: var delegate = /** @type
{!WebInspector.ToolboxDelegate} */ (window.opener.WebInspector["app"]);
On 2014/08/13 13:47:33, dgozman wrote:
> Now that we are casting here, we can just
> |window.opener.WebInspector["app"].toolboxLoaded(....)| and don't bother with
> ToolboxDelegate. WDYT?

AdvancedApp should not be visible to the Toolbox, right? So, we still need this
type. One thing is that we can drop the "delegate" field and invoke
toolboxLoaded() directly on the cast value, but that is a different point.

[apavlov, 2014-08-13 13:51:48]

https://codereview.chromium.org/460673003/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/main/Toolbox.js (right):

https://codereview.chromium.org/460673003/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/main/Toolbox.js:31: var delegate = /** @type
{!WebInspector.ToolboxDelegate} */ (window.opener.WebInspector["app"]);
On 2014/08/13 13:47:33, dgozman wrote:
> Now that we are casting here, we can just
> |window.opener.WebInspector["app"].toolboxLoaded(....)| and don't bother with
> ToolboxDelegate. WDYT?

Ah, I get your point now. No, the compiler will not allow to invoke an arbitrary
method on an unknown type.

[dgozman, 2014-08-13 14:00:14]

lgtm

[apavlov, 2014-08-13 14:00:45]

The CQ bit was checked by apavlov@chromium.org

[commit-bot: I haz the power, 2014-08-13 14:01:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/apavlov@chromium.org/460673003/20001

[commit-bot: I haz the power, 2014-08-13 15:05:20]

Committed patchset #2 (20001) as 180178