Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 460673002: bindings: Changes DOMWrapperMap::KeyType to ScriptWrappableBase*. (Closed)

Created:
6 years, 4 months ago by Yuki
Modified:
6 years, 4 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Changes DOMDataStore's map type from DOMWrapperMap<void> to DOMWrapperMap<ScriptWrappableBase>. BUG=235436 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179958

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M Source/bindings/core/v8/DOMDataStore.h View 1 1 chunk +11 lines, -1 line 0 comments Download
M Source/bindings/core/v8/DOMWrapperMap.h View 1 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yuki
Could you review this CL?
6 years, 4 months ago (2014-08-11 13:32:06 UTC) #1
haraken
LGTM
6 years, 4 months ago (2014-08-11 13:35:29 UTC) #2
Yuki
The CQ bit was checked by yukishiino@chromium.org
6 years, 4 months ago (2014-08-11 13:42:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/460673002/20001
6 years, 4 months ago (2014-08-11 13:42:36 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 14:46:13 UTC) #5
Message was sent while issue was closed.
Change committed as 179958

Powered by Google App Engine
This is Rietveld 408576698