src/compiler/structured-machine-assembler.cc - Issue 460633002: Remove duplication in Scheduler and simplify interface. Make ComputeSchedule() and ComputeSpecialRP…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/structured-machine-assembler.cc

Issue 460633002: Remove duplication in Scheduler and simplify interface. Make ComputeSchedule() and ComputeSpecialRP… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/structured-machine-assembler.cc

diff --git a/src/compiler/structured-machine-assembler.cc b/src/compiler/structured-machine-assembler.cc

index 7d9ab870ae8b59fcd87c91246289b4484389826f..1e46a2306586f73590d6fd38aa872d33f58e38ee 100644

--- a/src/compiler/structured-machine-assembler.cc

+++ b/src/compiler/structured-machine-assembler.cc

@@ -41,8 +41,7 @@ StructuredMachineAssembler::StructuredMachineAssembler(

Schedule* StructuredMachineAssembler::Export() {

// Compute the correct codegen order.

DCHECK(schedule_->rpo_order()->empty());

- Scheduler scheduler(zone(), graph(), schedule_);

- scheduler.ComputeSpecialRPO();

+ Scheduler::ComputeSpecialRPO(schedule_);

// Invalidate MachineAssembler.

Schedule* schedule = schedule_;

schedule_ = NULL;

« no previous file with comments | « src/compiler/scheduler.cc ('k') | test/cctest/compiler/test-instruction.cc » ('j') | no next file with comments »