Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 460633002: Remove duplication in Scheduler and simplify interface. Make ComputeSchedule() and ComputeSpecialRP… (Closed)

Created:
6 years, 4 months ago by titzer
Modified:
6 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Remove duplication in Scheduler and simplify interface. Make ComputeSchedule() and ComputeSpecialRPO() the only interface used by clients. R=bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=23039

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -124 lines) Patch
M src/compiler/pipeline.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/scheduler.h View 2 chunks +8 lines, -5 lines 0 comments Download
M src/compiler/scheduler.cc View 10 chunks +31 lines, -49 lines 0 comments Download
M src/compiler/structured-machine-assembler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/compiler/test-instruction.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/compiler/test-scheduler.cc View 47 chunks +31 lines, -62 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
titzer
6 years, 4 months ago (2014-08-11 12:12:31 UTC) #1
Benedikt Meurer
lgtm
6 years, 4 months ago (2014-08-11 12:13:25 UTC) #2
titzer
6 years, 4 months ago (2014-08-11 13:07:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 23039 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698