Issue 46063006: CRLF -> LF in giant-stylesheet-crash.html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 46063006: CRLF -> LF in giant-stylesheet-crash.html (Closed)

Created:
7 years, 1 month ago by rune

Modified:
7 years, 1 month ago

Reviewers:
ojan, eseidel

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

CRLF -> LF in giant-stylesheet-crash.html Not able to apply another patch from rietveld due to CRLF issues. TBR=ojan@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160658

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -25 lines)			Patch
	M	LayoutTests/fast/css/giant-stylesheet-crash.html	View		1 chunk	+25 lines, -25 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rune

Committed patchset #1 manually as r160658 (presubmit successful).

7 years, 1 month ago (2013-10-26 17:25:36 UTC) #1

eseidel

I thought the magic was that we just set the proper svn/git flags and it ...

7 years, 1 month ago (2013-10-26 20:34:17 UTC) #2

rune

7 years, 1 month ago (2013-10-28 07:45:41 UTC) #3

Message was sent while issue was closed.

On 2013/10/26 20:34:17, eseidel wrote:
> I thought the magic was that we just set the proper svn/git flags and it
handled
> line endings like thsi for us?

OK. I'll do that the next time. Do you know if it's documented somewhere? How to
do it? I tried to search chromium.org without any luck.

Expand Messages | Collapse Messages