rebaseline_server: tiny fix to un-break UI when ng-repeate (key, value) has duplicate values

rebaseline_server: tiny fix to un-break UI when ng-repeate (key, value) has duplicate values

See https://github.com/angular/angular.js/pull/2505

(SkipBuildbotRuns)
TBR=jcgregorio

Committed: https://code.google.com/p/skia/source/detail?r=11972

[epoger, 2013-10-26 15:01:10]

Committed patchset #1 manually as r11972 (presubmit successful).

[epoger, 2013-10-26 15:01:40]

committed TBR=jcgregorio

[jcgregorio, 2013-10-28 14:24:22]

On 2013/10/26 15:01:40, epoger wrote:
> committed TBR=jcgregorio

LGTM

Looks like a safe change to me, but under what circumstances could you get
duplicates?

[epoger, 2013-10-28 20:56:27]

On 2013/10/28 14:24:22, jcgregorio wrote:
> On 2013/10/26 15:01:40, epoger wrote:
> > committed TBR=jcgregorio
> 
> LGTM
> 
> Looks like a safe change to me, but under what circumstances could you get
> duplicates?

The old code failed if there were duplicate *values* among the key-value pairs,
like this map of configs to number-of-instances-of-that-config:

{"565": 32, "8888": 32, "pdf": 15}

Why yes, I was surprised to find that this was a problem.

[jcgregorio, 2013-10-28 21:00:37]

On 2013/10/28 20:56:27, epoger wrote:
> On 2013/10/28 14:24:22, jcgregorio wrote:
> > On 2013/10/26 15:01:40, epoger wrote:
> > > committed TBR=jcgregorio
> > 
> > LGTM
> > 
> > Looks like a safe change to me, but under what circumstances could you get
> > duplicates?
> 
> The old code failed if there were duplicate *values* among the key-value
pairs,
> like this map of configs to number-of-instances-of-that-config:
> 
> {"565": 32, "8888": 32, "pdf": 15}
> 
> Why yes, I was surprised to find that this was a problem.

OK, that's very surprising behavior, and good to know, thanks!