Issue 46063004: Added crash_service as a dependency of chromium_gpu_{debug_}builder target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 46063004: Added crash_service as a dependency of chromium_gpu_{debug_}builder target. (Closed)

Created:
7 years, 1 month ago by Ken Russell (switch to Gerrit)

Modified:
7 years, 1 month ago

Reviewers:
Zhenyao Mo

CC:
chromium-reviews, cpu_(ooo_6.6-7.5)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Added crash_service as a dependency of chromium_gpu_{debug_}builder target. BUG=311826 R=zmo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231397

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -0 lines)			Patch
	M	build/all.gyp	View		2 chunks	+20 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Zhenyao Mo

On 2013/10/25 23:55:01, Ken Russell wrote: > Mo: please review. Thanks. LGTM

7 years, 1 month ago (2013-10-25 23:57:27 UTC) #2

Ken Russell (switch to Gerrit)

The try failures above are all unrelated to this change. Committing manually.

7 years, 1 month ago (2013-10-28 20:22:15 UTC) #3

Ken Russell (switch to Gerrit)

7 years, 1 month ago (2013-10-28 20:28:41 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r231397 (presubmit successful).