Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 460593002: Oilpan: tweak heuristics for forcing conservative GC. (Closed)

Created:
6 years, 4 months ago by Mads Ager (chromium)
Modified:
6 years, 4 months ago
CC:
blink-reviews, haraken, kouhei+heap_chromium.org, Mads Ager (chromium)
Project:
blink
Visibility:
Public.

Description

Oilpan: tweak heuristics for forcing conservative GC. Keep track of collection rate. If we collect less than 50% of objects, use a factor of 4 instead of 2 allocation to force conservative GCs. This will only have an effect when you do not get back to the event loop in a timely manner. That happens a lot in benchmarks and almost never in reality. R=erik.corry@gmail.com, zerny@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179949

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M Source/platform/heap/ThreadState.h View 3 chunks +6 lines, -0 lines 0 comments Download
M Source/platform/heap/ThreadState.cpp View 1 5 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mads Ager (chromium)
6 years, 4 months ago (2014-08-11 09:30:53 UTC) #1
Erik Corry
lgtm https://codereview.chromium.org/460593002/diff/1/Source/platform/heap/ThreadState.cpp File Source/platform/heap/ThreadState.cpp (right): https://codereview.chromium.org/460593002/diff/1/Source/platform/heap/ThreadState.cpp#newcode627 Source/platform/heap/ThreadState.cpp:627: // but not for less than 4Mbytes. // ...
6 years, 4 months ago (2014-08-11 10:24:06 UTC) #2
zerny-chromium
lgtm
6 years, 4 months ago (2014-08-11 10:29:42 UTC) #3
haraken
LGTM
6 years, 4 months ago (2014-08-11 10:46:14 UTC) #4
Mads Ager (chromium)
https://codereview.chromium.org/460593002/diff/1/Source/platform/heap/ThreadState.cpp File Source/platform/heap/ThreadState.cpp (right): https://codereview.chromium.org/460593002/diff/1/Source/platform/heap/ThreadState.cpp#newcode627 Source/platform/heap/ThreadState.cpp:627: // but not for less than 4Mbytes. On 2014/08/11 ...
6 years, 4 months ago (2014-08-11 12:21:31 UTC) #5
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 4 months ago (2014-08-11 12:21:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/460593002/20001
6 years, 4 months ago (2014-08-11 12:22:34 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-11 13:35:02 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 14:10:09 UTC) #9
Message was sent while issue was closed.
Change committed as 179949

Powered by Google App Engine
This is Rietveld 408576698