avoid >> ambiguity in gin test

avoid >> ambiguity in gin test

Followup from https://codereview.chromium.org/419673004

BUG=397554
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289129

[Mostyn Bramley-Moore, 2014-08-11 09:03:59]

@abarth, hansmuller: please take a look at this small fixup.

[abarth-chromium, 2014-08-11 18:00:41]

Does this error show up on the waterfall?

[Mostyn Bramley-Moore, 2014-08-11 18:10:44]

On 2014/08/11 18:00:41, abarth wrote:
> Does this error show up on the waterfall?

I'm not sure, I found this in local builds.

This convention (including a space) seems to be used elsewhere in the code base.

[Mostyn Bramley-Moore, 2014-08-11 18:10:45]

On 2014/08/11 18:00:41, abarth wrote:
> Does this error show up on the waterfall?

I'm not sure, I found this in local builds.

This convention (including a space) seems to be used elsewhere in the code base.

[hansmuller, 2014-08-11 19:15:02]

On 2014/08/11 18:10:45, Mostyn Bramley-Moore wrote:
> On 2014/08/11 18:00:41, abarth wrote:
> > Does this error show up on the waterfall?
> 
> I'm not sure, I found this in local builds.
> 
> This convention (including a space) seems to be used elsewhere in the code
base.

I thought the need to add a space to disambiguate closing a template from right
shift was archaic. On the other hand, you're right that our code base seems to
add the extra space; your change LGTM.

[abarth-chromium, 2014-08-11 19:15:02]

On 2014/08/11 at 18:10:45, mostynb wrote:
> On 2014/08/11 18:00:41, abarth wrote:
> > Does this error show up on the waterfall?
> 
> I'm not sure, I found this in local builds.
> 
> This convention (including a space) seems to be used elsewhere in the code
base.

I suspect this is a C++11 issue.  Using >> is allowed in C++11, and I believe
all the bots are configured currently to use the C++11 language rules.  If we
don't have any automated mechanisms to prevent us from doing this in the future,
we'll just regress this.

Can you configure your local compiler to use C++11?

[Mostyn Bramley-Moore, 2014-08-12 05:49:20]

> I suspect this is a C++11 issue.  Using >> is allowed in C++11, and I believe
> all the bots are configured currently to use the C++11 language rules.  If we
> don't have any automated mechanisms to prevent us from doing this in the
future,
> we'll just regress this.
> 
> Can you configure your local compiler to use C++11?

Not immediately, but I can keep this as a local patch until I can.

(Closing this issue.)

[abarth-chromium, 2014-08-12 17:32:58]

I think we should just land this CL.  I suspect you'll need to switch to C++11
soon though.

[abarth-chromium, 2014-08-12 17:33:01]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-08-12 17:35:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mostynb@opera.com/460583002/1

[commit-bot: I haz the power, 2014-08-12 19:10:07]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/40641)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-12 19:17:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-12 19:17:21]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Mostyn Bramley-Moore, 2014-08-12 19:32:59]

On 2014/08/12 17:32:58, abarth wrote:
> I think we should just land this CL.  I suspect you'll need to switch to C++11
> soon though.

Thanks, I appreciate it.  But I think you need to say the magic word for the CQ
first.

(I'm trying to make it until chromium 38 is released with as few local c++11
related patches as I can, after that I will focus on replacing these old
toolchains.)

[abarth-chromium, 2014-08-12 19:51:37]

lgtm

[commit-bot: I haz the power, 2014-08-12 20:32:03]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-08-12 20:36:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-12 20:36:43]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Mostyn Bramley-Moore, 2014-08-12 21:07:55]

The CQ bit was checked by mostynb@opera.com

[commit-bot: I haz the power, 2014-08-12 21:14:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mostynb@opera.com/460583002/1

[commit-bot: I haz the power, 2014-08-12 21:24:03]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Mostyn Bramley-Moore, 2014-08-12 21:30:33]

The CQ bit was checked by mostynb@opera.com

[commit-bot: I haz the power, 2014-08-12 21:36:26]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-08-12 21:37:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mostynb@opera.com/460583002/20001

[commit-bot: I haz the power, 2014-08-13 00:09:41]

Change committed as 289129