Pass highest handled invalidation version between invalidators

Pass highest handled invalidation version between invalidators

With this CL, device policy invalidation keeps track of the highest
invalidation version that has been handled (= policy has been reloaded
for this version already) when one invalidation is destroyed and another
created.

BUG=358699
TEST=WIP

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289411

[bartfab (slow), 2014-08-11 17:35:02]

Hi Steve,

Tests and comments are still missing but I wanted to send this to you before I
head home for the day. Could you take a look and let me know whether you see any
issues?

[Steve Condie, 2014-08-11 18:10:05]

lgtm

[bartfab (slow), 2014-08-13 10:11:39]

Hi Joao,

Could you take a look please?

[Joao da Silva, 2014-08-13 13:01:38]

lgtm

https://codereview.chromium.org/460573005/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/device_cloud_policy_invalidator.cc (right):

https://codereview.chromium.org/460573005/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/device_cloud_policy_invalidator.cc:122:
highest_handled_invalidation_version_(0) {
I don't know if invalidation IDs can be negative... maybe initialize this to
kint64min just in case? :-)

https://codereview.chromium.org/460573005/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/device_cloud_policy_invalidator_unittest.cc
(right):

https://codereview.chromium.org/460573005/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/device_cloud_policy_invalidator_unittest.cc:135:
*device_policy_.GetSigningKey());
nit: indent

https://codereview.chromium.org/460573005/diff/20001/chrome/browser/policy/cl...
File chrome/browser/policy/cloud/cloud_policy_invalidator_unittest.cc (right):

https://codereview.chromium.org/460573005/diff/20001/chrome/browser/policy/cl...
chrome/browser/policy/cloud/cloud_policy_invalidator_unittest.cc:452: 0     
/*highest_handled_invalidation_version*/);
nit: space after /* and before */ (same below)

[bartfab (slow), 2014-08-13 13:37:47]

https://codereview.chromium.org/460573005/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/device_cloud_policy_invalidator.cc (right):

https://codereview.chromium.org/460573005/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/device_cloud_policy_invalidator.cc:122:
highest_handled_invalidation_version_(0) {
On 2014/08/13 13:01:38, Joao da Silva wrote:
> I don't know if invalidation IDs can be negative... maybe initialize this to
> kint64min just in case? :-)

Yes, they can be negative and negative values are special. Zero is the correct
starting point.

I added a comment clarifying this and a DCHECK enforcing it.

https://codereview.chromium.org/460573005/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/device_cloud_policy_invalidator_unittest.cc
(right):

https://codereview.chromium.org/460573005/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/device_cloud_policy_invalidator_unittest.cc:135:
*device_policy_.GetSigningKey());
On 2014/08/13 13:01:38, Joao da Silva wrote:
> nit: indent

Done.

https://codereview.chromium.org/460573005/diff/20001/chrome/browser/policy/cl...
File chrome/browser/policy/cloud/cloud_policy_invalidator_unittest.cc (right):

https://codereview.chromium.org/460573005/diff/20001/chrome/browser/policy/cl...
chrome/browser/policy/cloud/cloud_policy_invalidator_unittest.cc:452: 0     
/*highest_handled_invalidation_version*/);
On 2014/08/13 13:01:38, Joao da Silva wrote:
> nit: space after /* and before */ (same below)

Done.

[bartfab (slow), 2014-08-13 13:37:47]

https://codereview.chromium.org/460573005/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/device_cloud_policy_invalidator.cc (right):

https://codereview.chromium.org/460573005/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/device_cloud_policy_invalidator.cc:122:
highest_handled_invalidation_version_(0) {
On 2014/08/13 13:01:38, Joao da Silva wrote:
> I don't know if invalidation IDs can be negative... maybe initialize this to
> kint64min just in case? :-)

Yes, they can be negative and negative values are special. Zero is the correct
starting point.

I added a comment clarifying this and a DCHECK enforcing it.

https://codereview.chromium.org/460573005/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/device_cloud_policy_invalidator_unittest.cc
(right):

https://codereview.chromium.org/460573005/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/device_cloud_policy_invalidator_unittest.cc:135:
*device_policy_.GetSigningKey());
On 2014/08/13 13:01:38, Joao da Silva wrote:
> nit: indent

Done.

https://codereview.chromium.org/460573005/diff/20001/chrome/browser/policy/cl...
File chrome/browser/policy/cloud/cloud_policy_invalidator_unittest.cc (right):

https://codereview.chromium.org/460573005/diff/20001/chrome/browser/policy/cl...
chrome/browser/policy/cloud/cloud_policy_invalidator_unittest.cc:452: 0     
/*highest_handled_invalidation_version*/);
On 2014/08/13 13:01:38, Joao da Silva wrote:
> nit: space after /* and before */ (same below)

Done.

[bartfab (slow), 2014-08-13 13:37:50]

The CQ bit was checked by bartfab@chromium.org

[commit-bot: I haz the power, 2014-08-13 13:38:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bartfab@chromium.org/460573005/40001

[commit-bot: I haz the power, 2014-08-13 23:15:23]

Committed patchset #3 (40001) as 289411