Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 460573004: Use resources/testharness.js for geometry-interfaces-dom-matrix test (Closed)

Created:
6 years, 4 months ago by zino
Modified:
6 years, 4 months ago
Reviewers:
pdr., krit, Rik
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Use resources/testharness.js for geometry-interfaces-dom-matrix test This way the test can be shared with other browser vendors and can be uploaded as part of the W3C test suite. This CL also removes duplicated test cases from previous version. BUG=388780 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180879

Patch Set 1 #

Patch Set 2 : TestExpectations #

Total comments: 3

Patch Set 3 : use testharnessreport.js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -191 lines) Patch
M LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html View 1 2 1 chunk +98 lines, -101 lines 0 comments Download
D LayoutTests/fast/dom/geometry-interfaces-dom-matrix-expected.txt View 1 2 1 chunk +0 lines, -90 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
zino
Please take a look.
6 years, 4 months ago (2014-08-11 13:41:10 UTC) #1
pdr.
https://codereview.chromium.org/460573004/diff/100001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/460573004/diff/100001/LayoutTests/TestExpectations#newcode1311 LayoutTests/TestExpectations:1311: crbug.com/388780 fast/dom/geometry-interfaces-dom-matrix.html [ NeedsRebaseline ] NeedsRebasline should not be ...
6 years, 4 months ago (2014-08-25 01:54:08 UTC) #2
pdr.
On 2014/08/25 01:54:08, pdr wrote: > https://codereview.chromium.org/460573004/diff/100001/LayoutTests/TestExpectations > File LayoutTests/TestExpectations (right): > > https://codereview.chromium.org/460573004/diff/100001/LayoutTests/TestExpectations#newcode1311 > ...
6 years, 4 months ago (2014-08-25 01:59:01 UTC) #3
zino
@pdr, Please take a look. I addressed all your comments. Thank you. https://codereview.chromium.org/460573004/diff/100001/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html File LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html ...
6 years, 4 months ago (2014-08-25 05:43:37 UTC) #4
pdr.
On 2014/08/25 05:43:37, zino wrote: > @pdr, > > Please take a look. > > ...
6 years, 4 months ago (2014-08-25 17:23:02 UTC) #5
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 4 months ago (2014-08-25 23:48:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/460573004/120001
6 years, 4 months ago (2014-08-25 23:49:21 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-26 00:43:16 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-26 02:34:44 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (120001) as 180879

Powered by Google App Engine
This is Rietveld 408576698