Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: Source/bindings/templates/methods.cpp

Issue 460573002: JS errors thrown in private scripts should be reported to stderr in Debug builds (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/templates/attributes.cpp ('k') | Source/bindings/tests/results/V8TestInterface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/methods.cpp
diff --git a/Source/bindings/templates/methods.cpp b/Source/bindings/templates/methods.cpp
index a7733bc9d8386b7c2f60793b417a4f9d0b38f431..0413a1cfb88410af8048eb78e7e8d4fa4b39ce03 100644
--- a/Source/bindings/templates/methods.cpp
+++ b/Source/bindings/templates/methods.cpp
@@ -525,6 +525,9 @@ bool {{v8_class}}::PrivateScript::{{method.name}}Method({{method.argument_declar
{% endif %}
ExceptionState exceptionState(ExceptionState::ExecutionContext, "{{method.name}}", "{{cpp_class}}", scriptState->context()->Global(), scriptState->isolate());
v8::TryCatch block;
+#ifndef NDEBUG
+ block.SetVerbose(true);
+#endif
V8RethrowTryCatchScope rethrow(block);
Jens Widell 2014/08/11 09:26:15 Unrelated: Using a V8RethrowTryCatchScope here is
haraken 2014/08/11 09:41:16 Makes a lot of sense. Will fix in a separate CL sh
{% if method.idl_type == 'void' %}
PrivateScriptRunner::runDOMMethod(scriptState, "{{cpp_class}}", "{{method.name}}", holder, {{method.arguments | length}}, argv);
« no previous file with comments | « Source/bindings/templates/attributes.cpp ('k') | Source/bindings/tests/results/V8TestInterface.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698