Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 460563003: Fix interchange of red and blue content when using rgba_4444_textures (Closed)

Created:
6 years, 4 months ago by USE eero AT chromium.org
Modified:
6 years, 4 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix interchange of red and blue content when using rgba_4444_textures Content is swizzled when texture format has different component order than expected format by platform. RGBA_4444 implies to use 4444 bits and does not affect component order. So, no need to swizzle contents. BUG=399634 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289266

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -2 lines) Patch
M AUTHORS View 2 chunks +2 lines, -1 line 0 comments Download
M cc/output/renderer_pixeltest.cc View 1 chunk +42 lines, -0 lines 5 comments Download
M cc/resources/platform_color.h View 1 chunk +1 line, -1 line 0 comments Download
A cc/test/data/blue.png View Binary file 0 comments Download

Messages

Total messages: 8 (0 generated)
USE eero AT chromium.org
As Sarath is out of office for a while, I took over his issue (https://codereview.chromium.org/434963002) ...
6 years, 4 months ago (2014-08-11 14:28:41 UTC) #1
enne (OOO)
https://codereview.chromium.org/460563003/diff/1/cc/output/renderer_pixeltest.cc File cc/output/renderer_pixeltest.cc (right): https://codereview.chromium.org/460563003/diff/1/cc/output/renderer_pixeltest.cc#newcode2128 cc/output/renderer_pixeltest.cc:2128: ResourceFormat texture_format = RGBA_4444; On 2014/08/11 14:28:40, e_hakkinen wrote: ...
6 years, 4 months ago (2014-08-11 19:59:38 UTC) #2
enne (OOO)
6 years, 4 months ago (2014-08-11 19:59:39 UTC) #3
USE eero AT chromium.org
https://codereview.chromium.org/460563003/diff/1/cc/output/renderer_pixeltest.cc File cc/output/renderer_pixeltest.cc (right): https://codereview.chromium.org/460563003/diff/1/cc/output/renderer_pixeltest.cc#newcode2128 cc/output/renderer_pixeltest.cc:2128: ResourceFormat texture_format = RGBA_4444; On 2014/08/11 19:59:37, enne wrote: ...
6 years, 4 months ago (2014-08-12 09:26:11 UTC) #4
enne (OOO)
Thanks, lgtm.
6 years, 4 months ago (2014-08-12 17:41:41 UTC) #5
USE eero AT chromium.org
The CQ bit was checked by e.hakkinen@samsung.com
6 years, 4 months ago (2014-08-13 07:45:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/e.hakkinen@samsung.com/460563003/1
6 years, 4 months ago (2014-08-13 07:47:39 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 11:27:35 UTC) #8
Message was sent while issue was closed.
Change committed as 289266

Powered by Google App Engine
This is Rietveld 408576698