Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 46055: RSS feed support (part 1), 2nd attempt (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 6 months ago by Finnur
Modified:
6 years, 2 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

RSS feed support (part 1), 2nd attempt. Part 1 is RSS feed auto-discovery. This will parse the web page header to find the feeds in the document and notify the browser to display the RSS icon in the toolbar. You can click on the icon, but it will just navigate to the first feed on the page, which (unless it has been designed to be browser friendly) will just dump XML as text on the user. For this reason I have disabled the code that makes the RSS icon appear and intend to enable it when we have a good landing page to display the XML. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11672

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+516 lines, -80 lines) Patch
A chrome/app/theme/rss.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/tab_contents_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/location_bar_view_gtk.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/location_bar_view_gtk.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/location_bar.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host_delegate.h View 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/navigation_entry.h View 3 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/web_contents.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/web_contents.cc View 1 2 chunks +24 lines, -0 lines 0 comments Download
M chrome/browser/toolbar_model.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/toolbar_model.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/views/location_bar_view.h View 6 chunks +67 lines, -12 lines 0 comments Download
M chrome/browser/views/location_bar_view.cc View 12 chunks +155 lines, -63 lines 0 comments Download
M chrome/common/render_messages.h View 4 chunks +73 lines, -1 line 0 comments Download
M chrome/common/render_messages_internal.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/renderer/render_view.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/renderer/render_view.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/test/test_location_bar.h View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/glue/feed.h View 1 chunk +46 lines, -0 lines 0 comments Download
M webkit/glue/webframe.h View 2 chunks +5 lines, -0 lines 0 comments Download
M webkit/glue/webframe_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webframe_impl.cc View 2 chunks +63 lines, -0 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 2 (0 generated)
Finnur
Same patch as before (previously reviewed as http://codereview.chromium.org/43109), except with 4 lines changed in web_contents.cc ...
8 years, 6 months ago (2009-03-13 20:58:27 UTC) #1
Evan Martin
8 years, 6 months ago (2009-03-13 21:45:43 UTC) #2
LGTM rubber stamp based on last review and discussion of minor tweak via chat :)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b