[SyncFS] Add last validate time in MDDB ver.4

[SyncFS] Add last validate time in MDDB ver.4

BUG=347425
TEST=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289921

[peria, 2014-08-15 04:40:01]

PTL.

[tzik, 2014-08-15 05:22:52]

https://codereview.chromium.org/460503004/diff/100001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/drive_backend/drive_backend_constants.h
(right):

https://codereview.chromium.org/460503004/diff/100001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/drive_backend_constants.h:25:
extern const char kLastValidTimeKey[];
s/Valid/Validation/ ?

https://codereview.chromium.org/460503004/diff/100001/chrome/browser/sync_fil...
File
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc
(right):

https://codereview.chromium.org/460503004/diff/100001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:730:
// Check if index is valid, if no validations run for more than 7 days.
for more than 7 days -> in 7 days?

https://codereview.chromium.org/460503004/diff/100001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:731:
const int64 kThresholdToValidate = 7;
Could you add "InDays" to the name?

https://codereview.chromium.org/460503004/diff/100001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:745:
base::Int64ToString(base::Time::Now().ToTimeT()));
Do Time::{To,From}InternalValue() work?

[peria, 2014-08-15 06:17:21]

https://codereview.chromium.org/460503004/diff/100001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/drive_backend/drive_backend_constants.h
(right):

https://codereview.chromium.org/460503004/diff/100001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/drive_backend_constants.h:25:
extern const char kLastValidTimeKey[];
On 2014/08/15 05:22:52, tzik wrote:
> s/Valid/Validation/ ?

Done.

https://codereview.chromium.org/460503004/diff/100001/chrome/browser/sync_fil...
File
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc
(right):

https://codereview.chromium.org/460503004/diff/100001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:730:
// Check if index is valid, if no validations run for more than 7 days.
On 2014/08/15 05:22:52, tzik wrote:
> for more than 7 days -> in 7 days?

Done.

https://codereview.chromium.org/460503004/diff/100001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:731:
const int64 kThresholdToValidate = 7;
On 2014/08/15 05:22:52, tzik wrote:
> Could you add "InDays" to the name?

Done.

https://codereview.chromium.org/460503004/diff/100001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:745:
base::Int64ToString(base::Time::Now().ToTimeT()));
On 2014/08/15 05:22:52, tzik wrote:
> Do Time::{To,From}InternalValue() work?

Done.

[tzik, 2014-08-15 06:48:10]

lgtm

https://codereview.chromium.org/460503004/diff/120001/chrome/browser/sync_fil...
File
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc
(right):

https://codereview.chromium.org/460503004/diff/120001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:739:
if (since_last_check.InDays() >= kThresholdToValidateInDays) {
Just in case, can we run the validation sequence in "since_last_check < 0" case?

[peria, 2014-08-15 06:57:04]

https://codereview.chromium.org/460503004/diff/120001/chrome/browser/sync_fil...
File
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc
(right):

https://codereview.chromium.org/460503004/diff/120001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:739:
if (since_last_check.InDays() >= kThresholdToValidateInDays) {
On 2014/08/15 06:48:10, tzik wrote:
> Just in case, can we run the validation sequence in "since_last_check < 0"
case?

Done.

[peria, 2014-08-15 07:03:44]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2014-08-15 07:06:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/peria@chromium.org/460503004/140001

[commit-bot: I haz the power, 2014-08-15 08:59:07]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[nhiroki, 2014-08-15 11:03:15]

lgtm with nit

https://codereview.chromium.org/460503004/diff/140001/chrome/browser/sync_fil...
File
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc
(right):

https://codereview.chromium.org/460503004/diff/140001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:84:
//   value: <time_t 'last_valid_time'>
I guess this should be int64 value and you may want to describe the way to
serialize/desirialize this value on the NOTE section.

[commit-bot: I haz the power, 2014-08-15 17:14:41]

Committed patchset #3 (140001) as 289921