Issue 460453003: Cleanup: Delete WebSolidColorLayer API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 460453003: Cleanup: Delete WebSolidColorLayer API. (Closed)

Created:
6 years, 4 months ago by tfarina

Modified:
6 years, 4 months ago

Reviewers:
tkent, abarth-chromium

CC:
abarth-chromium, blink-layers+watch_chromium.org, blink-reviews, Rik, danakj, dglazkov+blink, krit, enne (OOO), jamesr, jbroman, pdr., rwlbuis, Stephen Chennney

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Cleanup: Delete WebSolidColorLayer API. Chromium stopped overridding createSolidColorLayer() from WebCompositorSupport and inheriting from WebSolidColorLayer at https://src.chromium.org/viewvc/chrome?revision=288125&view=revision, and Blink removed the function at https://src.chromium.org/viewvc/blink?revision=179785&view=revision. BUG=None TEST=None R=tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179892

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -48 lines)			Patch
M	Source/platform/graphics/GraphicsLayer.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	public/platform/WebCompositorSupport.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	public/platform/WebSolidColorLayer.h	View	1 chunk	+0 lines, -45 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/460453003/1

6 years, 4 months ago (2014-08-10 15:41:40 UTC) #3

Message was sent while issue was closed.

Change committed as 179892

Expand Messages | Collapse Messages