Issue 46043019: GTTF: Add a flag controlling handling of test stdio by the new launcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 46043019: GTTF: Add a flag controlling handling of test stdio by the new launcher. (Closed)

Created:
7 years, 1 month ago by Paweł Hajdan Jr.

Modified:
7 years, 1 month ago

Reviewers:
hubbe

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

GTTF: Add a flag controlling handling of test stdio by the new launcher. Pass --test-launcher-test-stdio=always to always include test stdio in test launcher's standard output. BUG=236893 R=hubbe@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231665

Patch Set 1 #

Total comments: 2

Patch Set 2 : switch name #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -3 lines)			Patch
M	base/test/launcher/test_launcher.cc	View	1	1 chunk	+22 lines, -3 lines	0 comments	Download
M	base/test/test_switches.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	base/test/test_switches.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

hubbe

lgtm https://codereview.chromium.org/46043019/diff/1/base/test/test_switches.cc File base/test/test_switches.cc (right): https://codereview.chromium.org/46043019/diff/1/base/test/test_switches.cc#newcode27 base/test/test_switches.cc:27: "test-launcher-test-stdio"; How about: --test-launcher-print-stdio ?

7 years, 1 month ago (2013-10-29 20:07:30 UTC) #2

Paweł Hajdan Jr.

https://codereview.chromium.org/46043019/diff/1/base/test/test_switches.cc File base/test/test_switches.cc (right): https://codereview.chromium.org/46043019/diff/1/base/test/test_switches.cc#newcode27 base/test/test_switches.cc:27: "test-launcher-test-stdio"; On 2013/10/29 20:07:30, hubbe wrote: > How about: ...

7 years, 1 month ago (2013-10-29 23:00:45 UTC) #3

Paweł Hajdan Jr.

7 years, 1 month ago (2013-10-29 23:01:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r231665 (presubmit successful).

Expand Messages | Collapse Messages