Source/core/animation/Animation.h - Issue 46043014: Web Animations CSS: Unfreeze AnimationClock if sampling timelines does not trigger style recalc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/Animation.h

Issue 46043014: Web Animations CSS: Unfreeze AnimationClock if sampling timelines does not trigger style recalc (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Reinstate assert Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/animation/Animation.h

diff --git a/Source/core/animation/Animation.h b/Source/core/animation/Animation.h

index ee96c46e8b411a4e5e8309ca1f856520e96b89d8..75e89a9d65b0fc691d1ce1de1e4b1e561ddab33d 100644

--- a/Source/core/animation/Animation.h

+++ b/Source/core/animation/Animation.h

@@ -56,9 +56,10 @@ public:

Priority priority() const { return m_priority; }

protected:

- virtual void applyEffects(bool previouslyInEffect);

+ // Returns whether style recalc was triggered.

+ virtual bool applyEffects(bool previouslyInEffect);

virtual void clearEffects();

- virtual void updateChildrenAndEffects() const OVERRIDE FINAL;

+ virtual bool updateChildrenAndEffects() const OVERRIDE FINAL;

virtual void willDetach() OVERRIDE FINAL;

virtual double calculateTimeToEffectChange(double inheritedTime, double activeTime, Phase) const OVERRIDE FINAL;

« no previous file with comments | « LayoutTests/transitions/cancel-and-start-new-expected.txt ('k') | Source/core/animation/Animation.cpp » ('j') | Source/core/frame/FrameView.cpp » ('J')