Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Issue 46043012: IDL compiler: DOM node types for methods (Closed)

Created:
7 years, 1 month ago by Nils Barth (inactive)
Modified:
7 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

IDL compiler: DOM node types for methods Test-only, since already implemented generically when doing attributes. (Adding test b/c Perl has complicated logic, which we've replaced by refactored functions, but want to assert that this is done properly.) BUG=239771 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160797

Patch Set 1 #

Patch Set 2 : Typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -0 lines) Patch
M Source/bindings/tests/idls/TestObjectPython.idl View 1 1 chunk +6 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 1 3 chunks +121 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nils Barth (inactive)
7 years, 1 month ago (2013-10-29 06:47:37 UTC) #1
haraken
LGTM.
7 years, 1 month ago (2013-10-29 06:48:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/46043012/30001
7 years, 1 month ago (2013-10-29 06:50:24 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-10-29 06:55:20 UTC) #4
Message was sent while issue was closed.
Change committed as 160797

Powered by Google App Engine
This is Rietveld 408576698