Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 460423002: Fix CertLoader initialization on browser restart. (Closed)

Created:
6 years, 4 months ago by pneubeck (no reviews)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix CertLoader initialization on browser restart. This broke CertLoader initialization (e.g. required for configuring EAP-TLS networks) when a) the device was enterprise enrolled and the user has modified chrome://flags b) the browser crashed and restarted. BUG=399807, 401800 TEST=Enterprise enroll device, modify a flag on chrome://flags, restart, try to configure/connect to an EAP-TLS network with client certificate. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289267

Patch Set 1 #

Patch Set 2 : Missing parantheses. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M chrome/browser/chromeos/login/session/restore_after_crash_session_manager_delegate.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
pneubeck (no reviews)
not tested yet, but for timezone differences, please take an early look. Thanks!
6 years, 4 months ago (2014-08-12 16:12:26 UTC) #1
pneubeck (no reviews)
Hi David, could you quickly review this please. This should get ASAP into dev-channel. I ...
6 years, 4 months ago (2014-08-12 19:32:30 UTC) #2
pneubeck (no reviews)
@Nikita, can you please check the commit box if the change is fine? I'll be ...
6 years, 4 months ago (2014-08-13 02:49:45 UTC) #3
pneubeck (no reviews)
@Nikita, can you please check the commit box if the change is fine? I'll be ...
6 years, 4 months ago (2014-08-13 02:49:45 UTC) #4
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 4 months ago (2014-08-13 08:52:57 UTC) #5
Nikita (slow)
lgtm
6 years, 4 months ago (2014-08-13 08:52:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/460423002/20001
6 years, 4 months ago (2014-08-13 08:55:04 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 11:28:24 UTC) #8
Message was sent while issue was closed.
Change committed as 289267

Powered by Google App Engine
This is Rietveld 408576698