Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 460393003: Cleanup namespace usage in Source/core/{dom/* & fileapi/*} (Closed)

Created:
6 years, 4 months ago by Sunil Ratnu
Modified:
6 years, 4 months ago
CC:
aboxhall, blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, dmazzoni, eae+blinkwatch, kinuko+fileapi, nhiroki, rwlbuis, sof, tzik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Cleanup namespace usage in Source/core/{dom/* and fileapi/*} Cleanup namespace usage in Source/core/{dom/* and fileapi/*} - Remove unnecessary blink:: prefixes - Make blank lines consistent BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180182

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Removed extra blank line #

Patch Set 4 : Fix Error and Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -49 lines) Patch
M Source/core/accessibility/AXMediaControls.cpp View 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Document.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/ExecutionContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ExecutionContextClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MessageChannel.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/MessagePort.h View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/core/dom/MessagePort.cpp View 5 chunks +11 lines, -11 lines 0 comments Download
M Source/core/dom/Microtask.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Microtask.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/QualifiedName.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Range.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/RenderedDocumentMarker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ViewportDescription.cpp View 1 2 3 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/dom/VisitedLinkState.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/fileapi/File.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fileapi/FileReaderLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
Sunil Ratnu
Please review this. Thanks!
6 years, 4 months ago (2014-08-12 20:43:21 UTC) #1
abarth-chromium
lgtm
6 years, 4 months ago (2014-08-12 21:05:20 UTC) #2
Sunil Ratnu
The CQ bit was checked by sunil.ratnu@samsung.com
6 years, 4 months ago (2014-08-12 21:11:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/460393003/40001
6 years, 4 months ago (2014-08-12 21:12:08 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-12 22:20:19 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 22:31:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_blink_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_rel/builds/9433)
6 years, 4 months ago (2014-08-12 22:31:27 UTC) #7
Sunil Ratnu
The CQ bit was checked by sunil.ratnu@samsung.com
6 years, 4 months ago (2014-08-13 12:43:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/460393003/60001
6 years, 4 months ago (2014-08-13 12:44:58 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-13 13:27:22 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 13:30:54 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/7327)
6 years, 4 months ago (2014-08-13 13:30:55 UTC) #12
Sunil Ratnu
The CQ bit was checked by sunil.ratnu@samsung.com
6 years, 4 months ago (2014-08-13 15:12:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/460393003/60001
6 years, 4 months ago (2014-08-13 15:13:00 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 15:14:19 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (60001) as 180182

Powered by Google App Engine
This is Rietveld 408576698